You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/27 19:47:36 UTC

[GitHub] [camel] cunningt opened a new pull request, #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

cunningt opened a new pull request, #8783:
URL: https://github.com/apache/camel/pull/8783

   https://issues.apache.org/jira/browse/CAMEL-18757
   
   Check the model of each component for the packaging type.    If a pom, express that in the parent and the bom.
   
   Did some parent/pom.xml cleanup as well - I checked through the entries for core, dsl, and catalog and added dependency entries for any missing artifacts under those sections.     Fixed some spacing issues in parent/pom.xml generation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #8783:
URL: https://github.com/apache/camel/pull/8783


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8783:
URL: https://github.com/apache/camel/pull/8783#issuecomment-1328336570

   :no_entry_sign: There are (likely) no components to be tested in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8783:
URL: https://github.com/apache/camel/pull/8783#issuecomment-1328357979

   ### Components tested:
   
   | Total | Tested | Failed :x: | Passed :white_check_mark: | 
   | --- | --- | --- |  --- |
   | 1 | 1 | 0 | 1 |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] cunningt commented on pull request #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

Posted by GitBox <gi...@apache.org>.
cunningt commented on PR #8783:
URL: https://github.com/apache/camel/pull/8783#issuecomment-1328978026

   Can definitely make that change but in the other projects that I've checked (cxf, karaf) the type isn't included for maven-plugin.   ` <type>pom</type>` is an issue because no jars exist for that dependency type and it causes errors on certain bom resolution programs that default to looking for a jar.    In the case of maven-plugins, a jar definitely exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8783:
URL: https://github.com/apache/camel/pull/8783#issuecomment-1328992773

   Okay its fine if others dont do that - also I dont think its a real problem, for end users that import this BOM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #8783: CAMEL-18757 Specify type for pom-only artifacts like camel-*-parent

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8783:
URL: https://github.com/apache/camel/pull/8783#issuecomment-1328687649

   I wonder if maven plugins such as
   ```
    <dependency>
           <groupId>org.apache.camel</groupId>
           <artifactId>camel-vertx-kafka-maven-plugin</artifactId>
           <version>${project.version}</version>
         </dependency>
   ```
   
   Should have
   
   ```
   <type>maven-plugin</type>
   ```
   https://maven.apache.org/ref/3.8.6/maven-core/artifact-handlers.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org