You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2008/02/09 00:39:07 UTC
[jira] Created: (SLING-242) Sling decodes request parameter again
Sling decodes request parameter again
-------------------------------------
Key: SLING-242
URL: https://issues.apache.org/jira/browse/SLING-242
Project: Sling
Issue Type: Bug
Reporter: Tobias Bocanegra
Priority: Critical
eg, sending a urlencoded post with:
date = Sat Feb 09 2008 00:26:16 GMT+0100
it is decoded again in the 'EncodedRequestParameter' and results in
Sat Feb 09 2008 00:26:16 GMT 0100
the decoding is not needed at all, since the servlet container already decodes it. this is also true for GET queries.
Example:
test.jsp:
"<%= request.getParameter("test") %>"
http://localhost:5003/sling/test.jsp.html?test=foo%2bbar
Prints: "foo bar" instead of "foo+bar"
http://localhost:5003/sling/test.jsp.html?test=100%2565
Prints: "100e" instead of "100%65"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-242) Sling decodes request parameter again
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-242:
---------------------------------------
Assignee: Felix Meschberger
> Sling decodes request parameter again
> -------------------------------------
>
> Key: SLING-242
> URL: https://issues.apache.org/jira/browse/SLING-242
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Priority: Critical
>
> eg, sending a urlencoded post with:
> date = Sat Feb 09 2008 00:26:16 GMT+0100
> it is decoded again in the 'EncodedRequestParameter' and results in
> Sat Feb 09 2008 00:26:16 GMT 0100
> the decoding is not needed at all, since the servlet container already decodes it. this is also true for GET queries.
> Example:
> test.jsp:
> "<%= request.getParameter("test") %>"
> http://localhost:5003/sling/test.jsp.html?test=foo%2bbar
> Prints: "foo bar" instead of "foo+bar"
> http://localhost:5003/sling/test.jsp.html?test=100%2565
> Prints: "100e" instead of "100%65"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-242) Sling decodes request parameter again
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567804#action_12567804 ]
Felix Meschberger commented on SLING-242:
-----------------------------------------
Interim fix committed in Rev. 620595.
Real fix should actually cleanup the EncodedRequestParameter class.
> Sling decodes request parameter again
> -------------------------------------
>
> Key: SLING-242
> URL: https://issues.apache.org/jira/browse/SLING-242
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Priority: Critical
>
> eg, sending a urlencoded post with:
> date = Sat Feb 09 2008 00:26:16 GMT+0100
> it is decoded again in the 'EncodedRequestParameter' and results in
> Sat Feb 09 2008 00:26:16 GMT 0100
> the decoding is not needed at all, since the servlet container already decodes it. this is also true for GET queries.
> Example:
> test.jsp:
> "<%= request.getParameter("test") %>"
> http://localhost:5003/sling/test.jsp.html?test=foo%2bbar
> Prints: "foo bar" instead of "foo+bar"
> http://localhost:5003/sling/test.jsp.html?test=100%2565
> Prints: "100e" instead of "100%65"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-242) Sling decodes request parameter again
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-242.
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Cleaned up the parameter code preventing unneeded round trips to byte[] for parameters retrieved from the servlet container.
Fixed in Rev. 636559
> Sling decodes request parameter again
> -------------------------------------
>
> Key: SLING-242
> URL: https://issues.apache.org/jira/browse/SLING-242
> Project: Sling
> Issue Type: Bug
> Reporter: Tobias Bocanegra
> Assignee: Felix Meschberger
> Priority: Critical
> Fix For: 2.0.0
>
>
> eg, sending a urlencoded post with:
> date = Sat Feb 09 2008 00:26:16 GMT+0100
> it is decoded again in the 'EncodedRequestParameter' and results in
> Sat Feb 09 2008 00:26:16 GMT 0100
> the decoding is not needed at all, since the servlet container already decodes it. this is also true for GET queries.
> Example:
> test.jsp:
> "<%= request.getParameter("test") %>"
> http://localhost:5003/sling/test.jsp.html?test=foo%2bbar
> Prints: "foo bar" instead of "foo+bar"
> http://localhost:5003/sling/test.jsp.html?test=100%2565
> Prints: "100e" instead of "100%65"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.