You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2014/12/02 19:55:40 UTC
[GitHub] incubator-streams pull request: rolling back https://github.com/ap...
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/152
rolling back https://github.com/apache/incubator-streams/pull/140
to address critical test failures per STREAMS-238
STREAMS-230 should be re-opened
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-238
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/152.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #152
----
commit fd86c8feada17fe1dd9bcdd94305c68685a8bb6e
Author: sblackmon <sb...@w2odigital.com>
Date: 2014-12-02T18:54:40Z
rolling back https://github.com/apache/incubator-streams/pull/140
to address critical test failures per STREAMS-238
STREAMS-230 should be re-opened
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: rolling back https://github.com/ap...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/152#issuecomment-65285251
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: rolling back https://github.com/ap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: rolling back https://github.com/ap...
Posted by steveblackmon <gi...@git.apache.org>.
Github user steveblackmon commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/152#discussion_r21182611
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java ---
@@ -316,6 +315,7 @@ protected void setupComponentTasks(Map<String, List<StreamsTask>> streamsTasks)
this.futures.put(task, this.executor.submit(task));
compTasks.add(task);
if( comp.isOperationCountable() ) {
+ this.monitor.submit(broadcastMonitor);
--- End diff --
this PR reverts to the version that existed before merging https://github.com/apache/incubator-streams/pull/140
we need to re-open STREAMS-230, dive a bit deeper into implications of the issue there, and take special care that the next attempt to address the issue does not cause any test failures, regular or sporadic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: rolling back https://github.com/ap...
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/152#discussion_r21182204
--- Diff: streams-runtimes/streams-runtime-local/src/main/java/org/apache/streams/local/builders/LocalStreamBuilder.java ---
@@ -316,6 +315,7 @@ protected void setupComponentTasks(Map<String, List<StreamsTask>> streamsTasks)
this.futures.put(task, this.executor.submit(task));
compTasks.add(task);
if( comp.isOperationCountable() ) {
+ this.monitor.submit(broadcastMonitor);
--- End diff --
Does this submit the broadcastMonitor regardless of the timeout that is set in the config? It'd be nice to have a way to not include it if the user wants to
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---