(datafusion) branch gh-readonly-queue/main/pr-26590-0ab1fd2fb9b99069473fb0c964d10952e59481f6 created (now c92d781659)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-26590-0ab1fd2fb9b99069473fb0c964d10952e59481f6
in repository https://gitbox.apache.org/repos/asf/datafusion.git


      at c92d781659 fix: restore all-features Clippy for DataFrame aggregate rewrites (#26590)

This branch includes the following new commits:

     new c92d781659 fix: restore all-features Clippy for DataFrame aggregate rewrites (#26590)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org

(datafusion) 01/01: fix: restore all-features Clippy for DataFrame aggregate rewrites (#26590)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-26590-0ab1fd2fb9b99069473fb0c964d10952e59481f6
in repository https://gitbox.apache.org/repos/asf/datafusion.git

commit c92d781659aec01fdf8fefa13161ef368895c685
Author: Kumar Ujjawal <uj...@gmail.com>
AuthorDate: Fri Oct 23 04:18:15 2026 +0000

    fix: restore all-features Clippy for DataFrame aggregate rewrites (#26590)
    
    ## Which issue does this PR close?
    
    Closes #26181.
    
    ## Rationale for this change
    
    On `main` at `2717e25625ff0c51c1805f8df52d317979db74ec`, `cargo clippy
    --all-targets --all-features -- -D warnings` fails with two
    `clippy::mutable_key_type` errors in `alias_aggregate_exprs` and
    `rewrite_select_aggs`.
    
    The diagnostics follow `Expr` through nested `ScalarValue` arrays to
    Arrow's `TrackedReservation`. That mutable memory accounting does not
    affect expression equality or hashing. The earlier `PushDownFilter`
    occurrences discussed in #26189 are already fixed on `main`.
    
    ## What changes are included in this PR?
    
    Add explained lint allowances on the aggregate rewrite map declaration
    and `rewrite_select_aggs`, following existing `Expr` key handling. No
    runtime code changes.
    
    ## What is the testing strategy for this PR?
    
    - Reproduced both errors on unmodified `main`; the exact command passes
    with this change.
    - `cargo fmt --all` and `git diff --check` pass.
    - `uv run ./dev/rust_lint.sh` passes, including CI Clippy, dependency
    checks, and documentation builds.
    - All 240 existing DataFrame integration tests pass, including
    `test_dataframe_api_select_semantics`, aggregate aliases, and name
    collisions.
    - Extended workspace validation passes: 12,819 Rust tests passed, 8
    ignored, and 538 SQL logic test files completed:
    
      ```sh
      RUST_BACKTRACE=1 cargo test --profile ci \
    --exclude datafusion-examples --exclude datafusion-benchmarks --exclude
    datafusion-cli \
        --workspace --lib --tests --bins \
    --features
    avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption
      ```
    
    No new runtime tests or benchmarks: this change adds only lint
    attributes and explanatory comments.
    
    ## Are there any user-facing changes?
    
    The documented all-features Clippy command passes again. No SQL behavior
    or public API changes.
---
 datafusion/core/src/dataframe/mod.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/datafusion/core/src/dataframe/mod.rs b/datafusion/core/src/dataframe/mod.rs
index d0738b9897..bce0ab44f8 100644
--- a/datafusion/core/src/dataframe/mod.rs
+++ b/datafusion/core/src/dataframe/mod.rs
@@ -298,6 +298,8 @@ fn alias_aggregate_exprs(
 ) -> Result<(Vec<Expr>, HashMap<Expr, Expr>)> {
     let exprs = normalize_cols(exprs, plan)?;
     let mut used = HashSet::new();
+    // Arrow buffer memory accounting does not affect expression equality or hashing.
+    #[allow(clippy::allow_attributes, clippy::mutable_key_type)]
     let mut rewrite_map = HashMap::new();
     let mut aliased = Vec::with_capacity(exprs.len());
     for expr in exprs {
@@ -318,6 +320,8 @@ fn alias_aggregate_exprs(
 }
 
 /// Replace aggregate subexpressions with columns produced by the Aggregate node.
+// Arrow buffer memory accounting does not affect expression equality or hashing.
+#[allow(clippy::allow_attributes, clippy::mutable_key_type)]
 fn rewrite_select_aggs(
     expr_list: Vec<SelectExpr>,
     input: &LogicalPlan,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org