You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/13 01:34:35 UTC

[GitHub] [flink] KurtYoung commented on a change in pull request #8407: [FLINK-12374][table-planner-blink] Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation.

KurtYoung commented on a change in pull request #8407: [FLINK-12374][table-planner-blink] Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation.
URL: https://github.com/apache/flink/pull/8407#discussion_r283167016
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/batch/BatchExecTableSourceScan.scala
 ##########
 @@ -75,7 +80,58 @@ class BatchExecTableSourceScan(
 
   override def translateToPlanInternal(
       tableEnv: BatchTableEnvironment): StreamTransformation[BaseRow] = {
-    throw new TableException("Implements this")
+    val config = tableEnv.getConfig
+    val bts = tableSource.asInstanceOf[BatchTableSource[_]]
+    val inputTransform = bts.getBoundedStream(tableEnv.streamEnv).getTransformation
+
+    val fieldIndexes = TableSourceUtil.computeIndexMapping(
+      tableSource,
+      isStreamTable = false,
+      None)
+
+    // check that declared and actual type of table source DataSet are identical
 
 Review comment:
   DataSet?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services