You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "YannByron (via GitHub)" <gi...@apache.org> on 2023/02/04 01:23:37 UTC

[GitHub] [hudi] YannByron opened a new pull request, #7849: [HUDI-xxx] Do not write change-data for compaction opertion

YannByron opened a new pull request, #7849:
URL: https://github.com/apache/hudi/pull/7849

   ### Change Logs
   
   _Describe context and summary for this change. Highlight if any code was copied._
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #7849:
URL: https://github.com/apache/hudi/pull/7849#discussion_r1096501910


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -80,21 +80,11 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
       TaskContextSupplier taskContextSupplier,
       Option<BaseKeyGenerator> keyGeneratorOpt) {
     if (table.requireSortedRecords()) {
-      if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
-        return new HoodieSortedMergeHandleWithChangeLog<>(writeConfig, instantTime, table, keyToNewRecords, partitionPath, fileId,
-            dataFileToBeMerged, taskContextSupplier, keyGeneratorOpt);

Review Comment:
   Let's keep the method name as `create` as is and just rollback the cdc supplemental log generation for compaction, and address in the release note that MOR table CDC is not supported for release 0.13.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] YannByron commented on a diff in pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on code in PR #7849:
URL: https://github.com/apache/hudi/pull/7849#discussion_r1096562129


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -80,21 +80,11 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
       TaskContextSupplier taskContextSupplier,
       Option<BaseKeyGenerator> keyGeneratorOpt) {
     if (table.requireSortedRecords()) {
-      if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
-        return new HoodieSortedMergeHandleWithChangeLog<>(writeConfig, instantTime, table, keyToNewRecords, partitionPath, fileId,
-            dataFileToBeMerged, taskContextSupplier, keyGeneratorOpt);

Review Comment:
   why claim the MOR table CDC is not supported?  This pr works.
   And the previous method name is not easy to distinguish.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #7849: [HUDI-5702] Avoid to write useless change-data when compaction

Posted by "alexeykudinkin (via GitHub)" <gi...@apache.org>.
alexeykudinkin commented on code in PR #7849:
URL: https://github.com/apache/hudi/pull/7849#discussion_r1096577976


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieMergeHandleFactory.java:
##########
@@ -80,21 +80,11 @@ public static <T, I, K, O> HoodieMergeHandle<T, I, K, O> create(
       TaskContextSupplier taskContextSupplier,
       Option<BaseKeyGenerator> keyGeneratorOpt) {
     if (table.requireSortedRecords()) {
-      if (table.getMetaClient().getTableConfig().isCDCEnabled()) {
-        return new HoodieSortedMergeHandleWithChangeLog<>(writeConfig, instantTime, table, keyToNewRecords, partitionPath, fileId,
-            dataFileToBeMerged, taskContextSupplier, keyGeneratorOpt);

Review Comment:
   @YannByron understand the intent, but capturing "compaction" in the name doesn't make sense. I see we capture in the java-doc that this method is meant for Compaction, that should be sufficient



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7849: [HUDI-5702] Avoid to write useless change-data when compaction

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7849:
URL: https://github.com/apache/hudi/pull/7849#issuecomment-1416804827

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14915",
       "triggerID" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14926",
       "triggerID" : "1416803568",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 2def194a44f5b3122dfebc98021403e86b0ce127 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14915) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14926) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #7849: [HUDI-5702] Avoid to write useless change-data when compaction

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on PR #7849:
URL: https://github.com/apache/hudi/pull/7849#issuecomment-1416835947

   ![Screen Shot 2023-02-04 at 1 49 40 PM](https://user-images.githubusercontent.com/2701446/216786941-c6b1653c-c4c3-46c3-baac-26ce56be0dad.png)
   
   CI passed. i will revert the name change then we can land


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7849:
URL: https://github.com/apache/hudi/pull/7849#issuecomment-1416615166

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2def194a44f5b3122dfebc98021403e86b0ce127 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7849:
URL: https://github.com/apache/hudi/pull/7849#issuecomment-1416663888

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14915",
       "triggerID" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2def194a44f5b3122dfebc98021403e86b0ce127 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14915) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #7849: [HUDI-5702] Avoid to write useless change-data when compaction

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan merged PR #7849:
URL: https://github.com/apache/hudi/pull/7849


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7849: [HUDI-xxx] Do not write change-data for compaction opertion

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7849:
URL: https://github.com/apache/hudi/pull/7849#issuecomment-1416624079

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14915",
       "triggerID" : "2def194a44f5b3122dfebc98021403e86b0ce127",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2def194a44f5b3122dfebc98021403e86b0ce127 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=14915) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] YannByron commented on pull request #7849: [HUDI-5702] Avoid to write useless change-data when compaction

Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on PR #7849:
URL: https://github.com/apache/hudi/pull/7849#issuecomment-1416803568

   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org