You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/06 09:04:40 UTC
[GitHub] [kafka] dongjinleekr opened a new pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.
dongjinleekr opened a new pull request #11472:
URL: https://github.com/apache/kafka/pull/11472
This is a bulk of trivial glitches I found while working on the other issues.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #11472:
URL: https://github.com/apache/kafka/pull/11472#issuecomment-969438136
@mimaison Here is the fix; redundant parameters to call `DumpLogSegments#[dumpLog, dumpTimeIndex]` in `DumpLogSegments#main` also had to be removed. After removing it, it works like a charm.
I am still curious why the scala compiler has been past this, explicit syntax errors. It may be related to `DumpLogSegments.dumpTimeIndex( ... Int.MaxValue)` I removed earlier, but I can't be certain yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison merged pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.
Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #11472:
URL: https://github.com/apache/kafka/pull/11472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dongjinleekr commented on pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.
Posted by GitBox <gi...@apache.org>.
dongjinleekr commented on pull request #11472:
URL: https://github.com/apache/kafka/pull/11472#issuecomment-962422176
@dajac Excuse me, could you have a look when you are free? I found the last one (`DefaultQuotaCallback#quotaMetricTags`) while working on [KAFKA-13341](https://issues.apache.org/jira/browse/KAFKA-13341). The static client-id quota is removed in 3.0.0 but still remains in the comments. (see: [KAFKA-13430](https://issues.apache.org/jira/browse/KAFKA-13430))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #11472: TRIVIAL: Remove unused parameters, exceptions, comments, etc.
Posted by GitBox <gi...@apache.org>.
mimaison commented on pull request #11472:
URL: https://github.com/apache/kafka/pull/11472#issuecomment-968910011
Thanks @dongjinleekr for the cleanup. It looks like you missed some changes in `DumpLogSegments.scala`:
```
[Error] /Users/mickael/github/kafka/core/src/main/scala/kafka/tools/DumpLogSegments.scala:62: too many arguments (found 7, expected 6) for method dumpLog: (file: java.io.File, printContents: Boolean, nonConsecutivePairsForLogFilesMap: scala.collection.mutable.Map[String,List[(Long, Long)]], isDeepIteration: Boolean, parser: kafka.tools.DumpLogSegments.MessageParser[_, _], skipRecordMetadata: Boolean): Unit
[Error] /Users/mickael/github/kafka/core/src/main/scala/kafka/tools/DumpLogSegments.scala:66: too many arguments (found 5, expected 4) for method dumpTimeIndex: (file: java.io.File, indexSanityOnly: Boolean, verifyOnly: Boolean, timeIndexDumpErrors: kafka.tools.DumpLogSegments.TimeIndexDumpErrors): Unit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org