readConfiguration() broken in juli

[Roger Keays <ro...@ninthavenue.com.au>]

Hi there,

I first ran into bug 39627 [1] when trying to get my logging working 
properly and got to have a pretty thorough read of the JULI code. I 
noticed that the readConfiguration(stream) method doesn't reset the 
configuration properly. It just calls a super.reset(), but the 
superclass doesn't know about the special per-classloader loggers.

Should I file a bug? I have a simple patch which just creates a new 
ClassLoaderLogInfo for every readConfiguration() call and lets the 
garbage collector to delete the old one.

I'm a bit confused about the way logging configuration is inherited by 
classloaders though. My patch doesn't reset any configuration in parent 
classloaders and I'm not sure what consequences this will have.

Roger

[1] http://issues.apache.org/bugzilla/show_bug.cgi?id=39627
-- 
----------------------------------------
Ninth Avenue Software
p: +61 7 3137 1351 (UTC +10)
f: +61 7 3102 9141
w: http://www.ninthavenue.com.au
e: info@ninthavenue.com.au
----------------------------------------

Re: readConfiguration() broken in juli

[Mark Thomas <ma...@apache.org>]

Roger Keays wrote:
> Should I file a bug? I have a simple patch which just creates a new
> ClassLoaderLogInfo for every readConfiguration() call and lets the
> garbage collector to delete the old one.

Patches are best attached to bug reports. They tend to get lost in the
noise on the lists if not acted on immediately.

Since this is a known issue, attach the patch to the bug report.

Mark

---------------------------------------------------------------------
To start a new topic, e-mail: users@tomcat.apache.org
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org