You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/15 18:24:34 UTC

[GitHub] [maven] kwin commented on a diff in pull request #872: [MNG-7597] Fix infinite loop when iterating PropertiesAsMap

kwin commented on code in PR #872:
URL: https://github.com/apache/maven/pull/872#discussion_r1023128378


##########
maven-core/src/main/java/org/apache/maven/internal/impl/PropertiesAsMap.java:
##########
@@ -71,6 +71,8 @@ public Entry<String, String> next()
                         {
                             throw new NoSuchElementException();
                         }
+                        Entry<Object, Object> next = this.next;
+                        this.next = null;

Review Comment:
   This should only be null once the final property key has been reached.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org