[trafficserver] 07/25: Discard packets instead of crash

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

maskit pushed a commit to branch quic-05
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit 15d5fa670f0c7f0dc0a5a644fe532b54e53517f9
Author: Masakazu Kitajo <ma...@apache.org>
AuthorDate: Tue Oct 3 16:20:46 2017 -0700

    Discard packets instead of crash
    
    This just avoids crashes. The packets need to be acked. (#2609)
    
    (cherry picked from commit 4abd02447216d925f0aaf3f26c5a6581eed4b7b8)
---
 iocore/net/QUICNetVConnection.cc | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/iocore/net/QUICNetVConnection.cc b/iocore/net/QUICNetVConnection.cc
index ddefb82..8801922 100644
--- a/iocore/net/QUICNetVConnection.cc
+++ b/iocore/net/QUICNetVConnection.cc
@@ -495,7 +495,11 @@ QUICNetVConnection::state_connection_closing(int event, Event *data)
   QUICErrorUPtr error = QUICErrorUPtr(new QUICNoError());
   switch (event) {
   case QUIC_EVENT_PACKET_READ_READY: {
-    error = this->_state_common_receive_packet();
+    if (this->_handshake_handler && this->_handshake_handler->is_completed()) {
+      error = this->_state_common_receive_packet();
+    } else {
+      // FIXME Just ignore for now but it has to be acked (GitHub#2609)
+    }
     break;
   }
   case QUIC_EVENT_PACKET_WRITE_READY: {
@@ -683,6 +687,9 @@ QUICNetVConnection::_state_common_receive_packet()
   case QUICPacketType::ONE_RTT_PROTECTED_KEY_PHASE_1:
     error = this->_state_connection_established_process_packet(std::move(p));
     break;
+  case QUICPacketType::CLIENT_CLEARTEXT:
+    // FIXME Just ignore for now but it has to be acked (GitHub#2609)
+   break;
   default:
     error = QUICErrorUPtr(new QUICConnectionError(QUICErrorClass::QUIC_TRANSPORT, QUICErrorCode::INTERNAL_ERROR));
     break;

-- 
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.