You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Ivanov, Alexey A" <al...@intel.com> on 2006/11/13 15:56:11 UTC

[doc] site.css

Hi all,

I've updated formatting of definition lists <DL> on site: https://issues.apache.org/jira/browse/HARMONY-2173

The new formatting looks more natural to me; the screenshots can be found in the JIRA issue.


When editing site.css I faced that there are many different styles of indentation used:
    * Some statements are indented using tabs,
    * Some -- using spaces,
    * And a mixture of tabs and space, in the worse case.

There are also inconsistencies in formatting of rules, and trailing white-space.

Let's agree on using either tabs or spaces for indentation of CSS statements. If they are different, it causes inconveniences when creating patches because some lines look changed while nothing was modified there.

I have no strong opinion on which one to use here. But let it be one: either tabs or spaces.

What do you think about it?


Thank you in advance,
--
Alexey A. Ivanov
Intel Enterprise Solutions Software Division

Re: [doc] site.css

Posted by Alexey Petrenko <al...@gmail.com>.
2006/11/14, Nathan Beyer <nb...@gmail.com>:
> Spaces only please!
+1

> On 11/13/06, Ivanov, Alexey A <al...@intel.com> wrote:
> > Hi all,
> >
> > I've updated formatting of definition lists <DL> on site: https://issues.apache.org/jira/browse/HARMONY-2173
> >
> > The new formatting looks more natural to me; the screenshots can be found in the JIRA issue.
> >
> >
> > When editing site.css I faced that there are many different styles of indentation used:
> >     * Some statements are indented using tabs,
> >     * Some -- using spaces,
> >     * And a mixture of tabs and space, in the worse case.
> >
> > There are also inconsistencies in formatting of rules, and trailing white-space.
> >
> > Let's agree on using either tabs or spaces for indentation of CSS statements. If they are different, it causes inconveniences when creating patches because some lines look changed while nothing was modified there.
> >
> > I have no strong opinion on which one to use here. But let it be one: either tabs or spaces.
> >
> > What do you think about it?
> >
> >
> > Thank you in advance,
> > --
> > Alexey A. Ivanov
> > Intel EnterpriseSolutions SoftwareDivision
> >
>

Re: [doc] site.css

Posted by Nathan Beyer <nb...@gmail.com>.
Spaces only please!

-Nathan

On 11/13/06, Ivanov, Alexey A <al...@intel.com> wrote:
> Hi all,
>
> I've updated formatting of definition lists <DL> on site: https://issues.apache.org/jira/browse/HARMONY-2173
>
> The new formatting looks more natural to me; the screenshots can be found in the JIRA issue.
>
>
> When editing site.css I faced that there are many different styles of indentation used:
>     * Some statements are indented using tabs,
>     * Some -- using spaces,
>     * And a mixture of tabs and space, in the worse case.
>
> There are also inconsistencies in formatting of rules, and trailing white-space.
>
> Let's agree on using either tabs or spaces for indentation of CSS statements. If they are different, it causes inconveniences when creating patches because some lines look changed while nothing was modified there.
>
> I have no strong opinion on which one to use here. But let it be one: either tabs or spaces.
>
> What do you think about it?
>
>
> Thank you in advance,
> --
> Alexey A. Ivanov
> Intel EnterpriseSolutions SoftwareDivision
>

Re: [doc] site.css

Posted by "Geir Magnusson Jr." <ge...@pobox.com>.

Ivanov, Alexey A wrote:
> Hi all,
> 
> I've updated formatting of definition lists <DL> on site: https://issues.apache.org/jira/browse/HARMONY-2173
> 
> The new formatting looks more natural to me; the screenshots can be found in the JIRA issue.

yes, that looks better.

> 
> 
> When editing site.css I faced that there are many different styles of indentation used:
>     * Some statements are indented using tabs,
>     * Some -- using spaces,
>     * And a mixture of tabs and space, in the worse case.
> 
> There are also inconsistencies in formatting of rules, and trailing white-space.
> 
> Let's agree on using either tabs or spaces for indentation of CSS statements. If they are different, it causes inconveniences when creating patches because some lines look changed while nothing was modified there.
> 
> I have no strong opinion on which one to use here. But let it be one: either tabs or spaces.
> 
> What do you think about it?

I think that since I don't have the first clue about css, and don't 
intend do it, you can choose :)

That said, I think that spaces are the right way - it's consistent w/ 
our other source formatting policies.

geir


> 
> 
> Thank you in advance,
> --
> Alexey A. Ivanov
> Intel Enterprise Solutions Software Division
>