[GitHub] [flink] godfreyhe commented on a diff in pull request #22427: [FLINK-30815][tests] Migrate BatchAbstractTestBase and BatchTestBase to junit5

["godfreyhe (via GitHub)" <gi...@apache.org>]

godfreyhe commented on code in PR #22427:
URL: https://github.com/apache/flink/pull/22427#discussion_r1178891930


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/LegacyTableSourceITCase.scala:
##########
@@ -347,7 +349,7 @@ class LegacyTableSourceITCase extends BatchTestBase {
          |)
        """.stripMargin
     tEnv.executeSql(ddl)
-    val resultPath = TEMPORARY_FOLDER.newFolder().getAbsolutePath
+    val resultPath = TempDirUtils.newFolder(BatchAbstractTestBase.tmpDir).getAbsolutePath

Review Comment:
   nit: can you provide an utility method in BatchAbstractTestBase to wrap `TempDirUtils.newFolder(BatchAbstractTestBase.tmpDir)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org