You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Koushik Das <ko...@citrix.com> on 2013/08/17 11:05:20 UTC
Review Request 13627: Fix for CLOUDSTACK-3441
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/
-----------------------------------------------------------
Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and Murali Reddy.
Bugs: CLOUDSTACK-3441
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
Diffs
-----
server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f
Diff: https://reviews.apache.org/r/13627/diff/
Testing
-------
Thanks,
Koushik Das
Re: Review Request 13627: Fix for CLOUDSTACK-3441
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/#review25365
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On Aug. 17, 2013, 9:32 a.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13627/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 9:32 a.m.)
>
>
> Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3441
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
>
> The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
>
> As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f
>
> Diff: https://reviews.apache.org/r/13627/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request 13627: Fix for CLOUDSTACK-3441
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/#review25402
-----------------------------------------------------------
Commit 5528ba4b20593e1c883507a1e161ccb48fffa57b in branch refs/heads/4.2-forward from Koushik Das
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5528ba4 ]
CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
- ASF Subversion and Git Services
On Aug. 17, 2013, 9:32 a.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13627/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 9:32 a.m.)
>
>
> Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3441
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
>
> The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
>
> As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f
>
> Diff: https://reviews.apache.org/r/13627/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request 13627: Fix for CLOUDSTACK-3441
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/#review25366
-----------------------------------------------------------
Commit 502c1db1030cfa01850127ba8a8e5e7b1eaf8ead in branch refs/heads/master from Koushik Das
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=502c1db ]
CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
- ASF Subversion and Git Services
On Aug. 17, 2013, 9:32 a.m., Koushik Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13627/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2013, 9:32 a.m.)
>
>
> Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and Murali Reddy.
>
>
> Bugs: CLOUDSTACK-3441
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
>
> The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
>
> As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f
>
> Diff: https://reviews.apache.org/r/13627/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Koushik Das
>
>
Re: Review Request 13627: Fix for CLOUDSTACK-3441
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13627/
-----------------------------------------------------------
(Updated Aug. 17, 2013, 9:32 a.m.)
Review request for cloudstack, Alex Huang, Abhinandan Prateek, Chiradeep Vittal, and Murali Reddy.
Bugs: CLOUDSTACK-3441
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3441: [Load Test] High delays between VM being allocated to Pod and network implementation causing delays in VM deployment
The locking code in implement/shutdown network code was not efficient. Even in order to check the current state of the network lock was getting acquired which is not required. This resulted in delays in deploy VM as can be seen from attached logs where the code waited on the lock just to check if network is implemented.
As part of the fix moved out code that is checking if the network is already implemented or shutdowned outside the lock.
Diffs (updated)
-----
server/src/com/cloud/network/NetworkManagerImpl.java 68b1b4f
Diff: https://reviews.apache.org/r/13627/diff/
Testing
-------
Thanks,
Koushik Das