[GitHub] [beam] TheNeuralBit commented on a change in pull request #15742: [BEAM-11936] Fix errorprone warnings

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #15742:
URL: https://github.com/apache/beam/pull/15742#discussion_r737770860



##########
File path: examples/java/src/main/java/org/apache/beam/examples/subprocess/ExampleEchoPipeline.java
##########
@@ -44,6 +44,7 @@
  * SubProcessPipelineOptions}
  */
 public class ExampleEchoPipeline {
+  @SuppressWarnings("unused")
   private static final Logger LOG = LoggerFactory.getLogger(ExampleEchoPipeline.class);

Review comment:
       If this logger isn't used let's just remove it (same comment in other places like this).

##########
File path: examples/kotlin/src/main/java/org/apache/beam/examples/kotlin/cookbook/DistinctExample.kt
##########
@@ -71,8 +71,6 @@ object DistinctExample {
             override fun create(options: PipelineOptions): String {
                 options.tempLocation.let {
                     return GcsPath.fromUri(it).resolve("deduped.txt").toString()
-                } ?: run {
-                    throw IllegalArgumentException("Must specify --output or --tempLocation")

Review comment:
       Is this something that errorprone caught? I didn't think it checked kotlin files

##########
File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java
##########
@@ -314,6 +314,7 @@ public OutputT expand(InputT input) {
                       .addAllArtifacts(artifacts)
                       .build())
               .getReplacementsList()) {
+        @SuppressWarnings("unused")
         RunnerApi.ArtifactInformation.Builder newArtifact = artifact.toBuilder();

Review comment:
       we should just remove this

##########
File path: examples/java/src/test/java/org/apache/beam/examples/complete/datatokenization/DataTokenizationTest.java
##########
@@ -137,7 +137,7 @@ public void testFileSystemIOReadJSON() throws IOException {
   @Test
   public void testJsonToRow() throws IOException {
     PCollection<Row> rows = fileSystemIORead(JSON_FILE_PATH, FORMAT.JSON);
-    SchemasUtils testSchemaUtils = new SchemasUtils(SCHEMA_FILE_PATH, StandardCharsets.UTF_8);
+    new SchemasUtils(SCHEMA_FILE_PATH, StandardCharsets.UTF_8);

Review comment:
       Do we need to construct this for some side effect? Or can we just remove the line entirely?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org