You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2015/09/08 23:34:09 UTC
[2/2] incubator-geode git commit: GEODE-77 reduced some health
monitor logging to trace level
GEODE-77 reduced some health monitor logging to trace level
During HA events I observed the health monitor create in excess of 1gb of
log entries per second. That's way too much for debug-level logging.
Project: http://git-wip-us.apache.org/repos/asf/incubator-geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-geode/commit/ddae0097
Tree: http://git-wip-us.apache.org/repos/asf/incubator-geode/tree/ddae0097
Diff: http://git-wip-us.apache.org/repos/asf/incubator-geode/diff/ddae0097
Branch: refs/heads/feature/GEODE-77
Commit: ddae00976e4510bf41aca6b7f87dd6b1b3df5574
Parents: 1002aa0
Author: Bruce Schuchardt <bs...@pivotal.io>
Authored: Tue Sep 8 14:33:50 2015 -0700
Committer: Bruce Schuchardt <bs...@pivotal.io>
Committed: Tue Sep 8 14:33:50 2015 -0700
----------------------------------------------------------------------
.../internal/membership/gms/fd/GMSHealthMonitor.java | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-geode/blob/ddae0097/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
----------------------------------------------------------------------
diff --git a/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
index 84f537d..613299a 100755
--- a/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
+++ b/gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
@@ -182,7 +182,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler {
long interval = memberTimeoutInMillis / GMSHealthMonitor.LOGICAL_INTERVAL;
long lastTS = currentTime - nextNeighbourTS.getTimeStamp();
if (lastTS + interval >= memberTimeoutInMillis) {
- logger.debug("Checking member {} ", neighbour);
+ logger.trace("Checking member {} ", neighbour);
// now do check request for this member;
checkMember(neighbour);
}
@@ -232,7 +232,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler {
String reason = String.format("Member isn't responding to check message: %s", pingMember);
GMSHealthMonitor.this.sendSuspectMessage(pingMember, reason);
} else {
- logger.debug("Setting next neighbour as member {} has not responded.", pingMember);
+ logger.trace("Setting next neighbour as member {} has not responded.", pingMember);
// back to previous one
setNextNeighbour(GMSHealthMonitor.this.currentView, null);
}
@@ -257,7 +257,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler {
*/
private boolean doCheckMember(InternalDistributedMember pingMember) {
//TODO: need to some tcp check
- logger.debug("Checking member {}", pingMember);
+ logger.trace("Checking member {}", pingMember);
final PingRequestMessage prm = constructPingRequestMessage(pingMember);
final Response pingResp = new Response();
requestIdVsResponse.put(prm.getRequestId(), pingResp);
@@ -266,7 +266,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler {
// TODO: send is throwing exception
if (membersNotReceivedMsg != null && membersNotReceivedMsg.contains(pingMember)) {
// member is not part of current view.
- logger.debug("Member {} is not part of current view.", pingMember);
+ logger.trace("Member {} is not part of current view.", pingMember);
} else {
synchronized (pingResp) {
if (pingResp.getResponseMsg() == null) {
@@ -396,7 +396,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler {
if (index != -1) {
int nextNeighbourIndex = (index + 1) % allMembers.size();
nextNeighbour = allMembers.get(nextNeighbourIndex);
- logger.debug("Next neighbour to check is {}", nextNeighbour);
+ logger.trace("Next neighbour to check is {}", nextNeighbour);
}
if (!sameView || memberVsLastMsgTS.size() == 0) {