[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

[GitBox <gi...@apache.org>]

vandonr-amz commented on code in PR #28528:
URL: https://github.com/apache/airflow/pull/28528#discussion_r1054925541


##########
airflow/sensors/base.py:
##########
@@ -256,14 +256,13 @@ def _get_next_poke_interval(
         return new_interval
 
     def prepare_for_execution(self) -> BaseOperator:
-        task = super().prepare_for_execution()
         # Sensors in `poke` mode can block execution of DAGs when running
         # with single process executor, thus we change the mode to`reschedule`
         # to allow parallel task being scheduled and executed
         if conf.get("core", "executor") == "DebugExecutor":
             self.log.warning("DebugExecutor changes sensor mode to 'reschedule'.")
-            task.mode = "reschedule"
-        return task
+            self.mode = "reschedule"

Review Comment:
   doing the change before calling the `super()` method, which returns a copy of `self`, so that the change is permanent.
   I don't really understand why we return a copy of the task here, so there might be implications to this change that I'm missing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org