[jira] [Commented] (STORM-1277) port backtype.storm.daemon.executor to java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401482#comment-15401482 ] 

ASF GitHub Bot commented on STORM-1277:
---------------------------------------

Github user unsleepy22 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1445#discussion_r72920746
  
    --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java ---
    @@ -179,23 +180,22 @@ public BuiltinMetrics getBuiltInMetrics() {
         private TopologyContext mkTopologyContext(StormTopology topology) throws IOException {
             Map conf = (Map) workerData.get("conf");
             return new TopologyContext(
    -            topology,
    -            (Map) workerData.get("storm-conf"),
    -            (Map<Integer, String>) workerData.get("task->component"),
    -            (Map<String, List<Integer>>) workerData.get("component->sorted-tasks"),
    -            (Map<String, Map<String, Fields>>) workerData.get("component->stream->fields"),
    -            (String) workerData.get("storm-id"),
    -            ConfigUtils.supervisorStormResourcesPath(ConfigUtils.supervisorStormDistRoot(conf, (String) workerData.get("storm-id"))),
    -            ConfigUtils.workerPidsRoot(conf, (String) workerData.get("worker-id")),
    -            taskId,
    -            (Integer) workerData.get("port"),
    -            (List<Integer>) workerData.get("task-ids"),
    -            (Map<String, Object>) workerData.get("default-shared-resources"),
    -            (Map<String, Object>) workerData.get("user-shared-resources"),
    -            (Map<String, Object>) executorData.get("shared-executor-data"),
    -            (Map<Integer, Map<Integer, Map<String, IMetric>>>) executorData.get("interval->task->metric-registry"),
    -            (clojure.lang.Atom) executorData.get("open-or-prepare-was-called?")
    -        );
    +                topology,
    +                (Map) workerData.get("storm-conf"),
    --- End diff --
    
    Oh, changed in StormCommon, but missed here. Will address.


> port backtype.storm.daemon.executor to java
> -------------------------------------------
>
>                 Key: STORM-1277
>                 URL: https://issues.apache.org/jira/browse/STORM-1277
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Cody
>              Labels: java-migration, jstorm-merger
>
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task kind of.  Tasks and executors are combined in jstorm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)