You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wusamzong (via GitHub)" <gi...@apache.org> on 2023/06/22 13:47:15 UTC
[GitHub] [yunikorn-k8shim] wusamzong opened a new pull request, #621: [YUNIKORN-1821] Fix shell script in authz use cases
wusamzong opened a new pull request, #621:
URL: https://github.com/apache/yunikorn-k8shim/pull/621
### What is this PR for?
When the shell script uses a two-dimensional array, if you use double quotes (required by shellcheck) when accessing variables, the access results will not be as expected. ex. `username: admin admin`
I split two-dimensional array to two array.
### What type of PR is it?
* [x] - Improvement
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1821/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #621: [YUNIKORN-1821] Fix shell script in authz use cases
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #621:
URL: https://github.com/apache/yunikorn-k8shim/pull/621#issuecomment-1603652257
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/621?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#621](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/621?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (03bd9c2) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/e9fa3f06287ab4e96c9509a1dac39c520f3c6cb4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e9fa3f0) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 70.87% 70.94% +0.06%
==========================================
Files 47 49 +2
Lines 7972 8125 +153
==========================================
+ Hits 5650 5764 +114
- Misses 2117 2151 +34
- Partials 205 210 +5
```
[see 4 files with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/621/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s commented on a diff in pull request #621: [YUNIKORN-1821] Fix shell script in authz use cases
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s commented on code in PR #621:
URL: https://github.com/apache/yunikorn-k8shim/pull/621#discussion_r1239296487
##########
deployments/examples/authz/k8s-api-access/create-user.sh:
##########
@@ -16,15 +16,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-USERS=("admin admin" "sue group-a" "bob group-a" "kim group-b" "yono group-b" "anonymous anonymous")
+USERS=("admin" "sue" "bob" "kim" "yono" "anonymous")
+USERS_GROUP=("admin" "group-a" "group-a" "group-b" "group-b" "anonymous")
Review Comment:
Add a comment that the user and group should contain the same number of elements.
If anyone wants no group or no user can we use an empty string, i.e. "" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] pbacsko closed pull request #621: [YUNIKORN-1821] Fix shell script in authz use cases
Posted by "pbacsko (via GitHub)" <gi...@apache.org>.
pbacsko closed pull request #621: [YUNIKORN-1821] Fix shell script in authz use cases
URL: https://github.com/apache/yunikorn-k8shim/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org