You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jiang13021 (via GitHub)" <gi...@apache.org> on 2023/09/09 04:35:29 UTC
[GitHub] [incubator-celeborn] jiang13021 opened a new pull request, #1894: [CELEBORN-961] Catch exception in constructor of Worker when starting Worker
jiang13021 opened a new pull request, #1894:
URL: https://github.com/apache/incubator-celeborn/pull/1894
… the Worker
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Move the constructor of Worker into a try-catch block.
### Why are the changes needed?
There are some exceptions thrown from Worker's constructor instead of Worker.initialize(), so it is necessary to catch these exceptions.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Start a worker with conf
```
celeborn.worker.directMemoryRatioToPauseReceive=0.7
celeborn.worker.directMemoryRatioToResume=0.7
```
an IllegalArgumentException will be caught
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] jiang13021 commented on pull request #1894: [CELEBORN-961] Catch exception when constructing Worker
Posted by "jiang13021 (via GitHub)" <gi...@apache.org>.
jiang13021 commented on PR #1894:
URL: https://github.com/apache/incubator-celeborn/pull/1894#issuecomment-1712468946
> LGTM, thanks! BTW, could you set your email address in your github account, so that the project can track? @jiang13021
OK, I've done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1894: [CELEBORN-961] Catch exception when constructing Worker
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1894:
URL: https://github.com/apache/incubator-celeborn/pull/1894#issuecomment-1712418685
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1894?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1894](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1894?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (981dcf4) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/7ab674393bb5b23d313c9c441ac478ef44ebe98d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7ab6743) will **decrease** coverage by `0.12%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1894 +/- ##
==========================================
- Coverage 46.63% 46.50% -0.12%
==========================================
Files 164 164
Lines 10226 10226
Branches 937 937
==========================================
- Hits 4768 4755 -13
- Misses 5145 5158 +13
Partials 313 313
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1894/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1894: [CELEBORN-961] Catch exception when constructing Worker
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #1894:
URL: https://github.com/apache/incubator-celeborn/pull/1894#issuecomment-1712470147
Thanks, merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture closed pull request #1894: [CELEBORN-961] Catch exception when constructing Worker
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #1894: [CELEBORN-961] Catch exception when constructing Worker
URL: https://github.com/apache/incubator-celeborn/pull/1894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org