You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jarosław (JIRA)" <ji...@apache.org> on 2017/06/30 19:59:00 UTC

[jira] [Updated] (WICKET-6412) Model#orElse behavior is inconsistent!

     [ https://issues.apache.org/jira/browse/WICKET-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarosław updated WICKET-6412:
-----------------------------
    Affects Version/s: 8.0.0-M6

> Model#orElse behavior is inconsistent!
> --------------------------------------
>
>                 Key: WICKET-6412
>                 URL: https://issues.apache.org/jira/browse/WICKET-6412
>             Project: Wicket
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M6
>            Reporter: Jarosław
>
> Dear Wicket Devs,
> I was very confused by Model#orElse method.
> Model and Optional have similar methods and these methods behave the same:
> {code}
> Optional<Integer> _optional = Optional.ofNullable("1").map(Integer::parseInt);
> IModel<Integer> _model = Model.of("1").map(Integer::parseInt);
> {code}
> Unfortunately "orElse" behavior is totally confusing!
> {code}
> Integer integer = _optional.orElse(0);
> IModel<Integer> integerIModel = _model.orElse(0); //WRONG!
> {code}
> It should return a Model's Object instead of Model itself!
> This definitely break the least surprise rule, so can you please change that before Wicket8 final release?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)