You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by PurelyApplied <gi...@git.apache.org> on 2017/05/19 18:59:13 UTC
[GitHub] geode pull request #522: GEODE-2953: Imports optimized in every file with a ...
GitHub user PurelyApplied opened a pull request:
https://github.com/apache/geode/pull/522
GEODE-2953: Imports optimized in every file with a wildcard import.
This is a purely semantic change. Imports have been optimized by my IDE. This may have the side-effect of changing some imports to static imports where applicable, as well as the ongoing disagreement between IntelliJ and Eclipse as to where `java` and `javax` imports belong.
All the same, precheckin up and running. Tests and Legacy already back green.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PurelyApplied/geode geode-2953
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #522
----
commit fc6ceffec0931575c9150087d11e7083fe9481c5
Author: Patrick Rhomberg <pr...@pivotal.io>
Date: 2017-05-19T18:18:47Z
GEODE-2953: Imports optimized in every file with a wildcard import.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/522
Please review the diff, or run a regex search matching `import .*\*;\n`. This regex hits 1024 occurrences in production and 2205 occurrences in test code.
Some of these occurrences are commented out. Matching `^import .*\*;\n` hits 827 production and 2175 test occurrences.
1388 classes going against best practices is indeed alarming, but I do not believe it is incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...
Posted by kohlmu-pivotal <gi...@git.apache.org>.
Github user kohlmu-pivotal commented on the issue:
https://github.com/apache/geode/pull/522
I really don't think that we should be doing this. Adds no value other than import reorganization....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/522
Upon further inspection, it appears that I neglected a good number of the test files. The PR has been updated and the commit message has been made more explicit. However, this means this PR now touches 1,807 files...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/522
Yeah, while I do firmly believe that there is value in good form and adherence to best practices, this PR ended up a lot bigger than I had initially expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #522: GEODE-2953: Imports optimized in every file with a ...
Posted by PurelyApplied <gi...@git.apache.org>.
Github user PurelyApplied closed the pull request at:
https://github.com/apache/geode/pull/522
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---