You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Evgeny Kotkov <ev...@visualsvn.com> on 2022/02/08 18:56:06 UTC

Re: svn commit: r1897207 - in /apr/apr/trunk: include/apr_thread_proc.h threadproc/beos/thread.c threadproc/netware/thread.c threadproc/os2/thread.c threadproc/unix/thread.c threadproc/win32/thread.c

Yann Ylavic <yl...@apache.org> writes:

> +APR_DECLARE(apr_status_t) apr_thread_current_create(apr_thread_t **current,
> +                                                    apr_threadattr_t *attr,
> +                                                    apr_pool_t *pool)
> +{
> +    apr_status_t stat;
> +
> +    *current = apr_thread_current();
> +    if (*current) {
> +        return APR_EEXIST;
> +    }
> +
> +    stat = alloc_thread(current, attr, NULL, NULL, pool);
> +    if (stat != APR_SUCCESS) {
> +        return stat;
> +    }
> +
> +    if (!(attr && attr->detach)) {
> +        (*new)->td = apr_os_thread_current();
> +    }

Hi Yann,

It looks like this hunk doesn't compile on Windows:

  …\threadproc\win32\thread.c(193): error C2065: 'new': undeclared identifier
  …\threadproc\win32\thread.c(193): error C2100: illegal indirection
  …\threadproc\win32\thread.c(193): error C2223: left of '->td' must point
  to struct/union


Thanks,
Evgeny Kotkov

Re: svn commit: r1897207 - in /apr/apr/trunk: include/apr_thread_proc.h threadproc/beos/thread.c threadproc/netware/thread.c threadproc/os2/thread.c threadproc/unix/thread.c threadproc/win32/thread.c

Posted by Yann Ylavic <yl...@gmail.com>.
On Tue, Feb 8, 2022 at 7:56 PM Evgeny Kotkov
<ev...@visualsvn.com> wrote:
>
> Yann Ylavic <yl...@apache.org> writes:
>
> > +APR_DECLARE(apr_status_t) apr_thread_current_create(apr_thread_t **current,
> > +                                                    apr_threadattr_t *attr,
> > +                                                    apr_pool_t *pool)
> > +{
> > +    apr_status_t stat;
> > +
> > +    *current = apr_thread_current();
> > +    if (*current) {
> > +        return APR_EEXIST;
> > +    }
> > +
> > +    stat = alloc_thread(current, attr, NULL, NULL, pool);
> > +    if (stat != APR_SUCCESS) {
> > +        return stat;
> > +    }
> > +
> > +    if (!(attr && attr->detach)) {
> > +        (*new)->td = apr_os_thread_current();
> > +    }
>
> Hi Yann,
>
> It looks like this hunk doesn't compile on Windows:
>
>   …\threadproc\win32\thread.c(193): error C2065: 'new': undeclared identifier
>   …\threadproc\win32\thread.c(193): error C2100: illegal indirection
>   …\threadproc\win32\thread.c(193): error C2223: left of '->td' must point
>   to struct/union

Thanks, hopefully fixed in r1897879.


Regards;
Yann.