You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Eric Shu <es...@pivotal.io> on 2016/04/13 02:20:10 UTC

Review Request 46124: GEODE-1221 Move implemented functions to test tree

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46124/
-----------------------------------------------------------

Review request for geode, Darrel Schneider and Swapnil Bawaskar.


Bugs: GEODE-1221
    https://issues.apache.org/jira/browse/GEODE-1221


Repository: geode


Description
-------

No longer supported use case. Move to test tree for future reference.


Diffs
-----

  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java 23139b4 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/NestedTransactionFunction.java 9e4aa9d 
  geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java f413d6c 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java 926a50a 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/CommitFunction.java PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NestedTransactionFunction.java PRE-CREATION 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RollbackFunction.java PRE-CREATION 

Diff: https://reviews.apache.org/r/46124/diff/


Testing
-------


Thanks,

Eric Shu


Re: Review Request 46124: GEODE-1221 Move implemented functions to test tree

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46124/#review128590
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On April 12, 2016, 5:20 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46124/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 5:20 p.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1221
>     https://issues.apache.org/jira/browse/GEODE-1221
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> No longer supported use case. Move to test tree for future reference.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java 23139b4 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/NestedTransactionFunction.java 9e4aa9d 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java f413d6c 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java 926a50a 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/CommitFunction.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NestedTransactionFunction.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RollbackFunction.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Shu
> 
>


Re: Review Request 46124: GEODE-1221 Move implemented functions to test tree

Posted by Swapnil Bawaskar <sb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46124/#review128715
-----------------------------------------------------------


Fix it, then Ship it!





geode-core/src/test/java/com/gemstone/gemfire/internal/cache/CommitFunction.java (line 138)
<https://reviews.apache.org/r/46124/#comment192180>

    please remove this bug number



geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RollbackFunction.java (line 133)
<https://reviews.apache.org/r/46124/#comment192179>

    please remove this bug number


- Swapnil Bawaskar


On April 13, 2016, 12:20 a.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46124/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 12:20 a.m.)
> 
> 
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
> 
> 
> Bugs: GEODE-1221
>     https://issues.apache.org/jira/browse/GEODE-1221
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> No longer supported use case. Move to test tree for future reference.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/CommitFunction.java 23139b4 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/NestedTransactionFunction.java 9e4aa9d 
>   geode-core/src/main/java/com/gemstone/gemfire/internal/cache/execute/util/RollbackFunction.java f413d6c 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java 926a50a 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/CommitFunction.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/NestedTransactionFunction.java PRE-CREATION 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RollbackFunction.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46124/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Shu
> 
>