You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Eli Collins (Created) (JIRA)" <ji...@apache.org> on 2011/12/14 22:05:30 UTC
[jira] [Created] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Add interface and update CLI to query current state to HAServiceProtocol
------------------------------------------------------------------------
Key: HADOOP-7925
URL: https://issues.apache.org/jira/browse/HADOOP-7925
Project: Hadoop Common
Issue Type: Sub-task
Affects Versions: HA Branch (HDFS-1623)
Reporter: Eli Collins
Assignee: Eli Collins
Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Aaron T. Myers (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HADOOP-7925:
-----------------------------------
Component/s: ha
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: hadoop-7925.txt, hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172033#comment-13172033 ]
Todd Lipcon commented on HADOOP-7925:
-------------------------------------
+1 from me too, committing momentarily
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt, hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169931#comment-13169931 ]
Uma Maheswara Rao G commented on HADOOP-7925:
---------------------------------------------
Eli, Patch looks good to me.
One small comment:
Looks we are spreading the "active", "standby" string literals in common and hdfs. If some one changes toString value of ActiveState in HDFS and prints the value somewhere that may give the new value of state, at the same time we must change common also.
My suggestion is to keep this literals in Enum itself and provide the toString of it. We can use this in both the places now. This is just suggestion, what do you say?
Also we need not have the state comparision checks.
{code}
enum HAServiceState {
ACTIVE("active"),
STANDBY("standby");
private String state = null;
HAServiceState(String state)
{
this.state = state;
}
public String toString()
{
return this.state;
}
}
{code}
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Todd Lipcon (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon resolved HADOOP-7925.
---------------------------------
Resolution: Fixed
Fix Version/s: HA Branch (HDFS-1623)
Hadoop Flags: Reviewed
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: hadoop-7925.txt, hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7925:
--------------------------------
Attachment: hadoop-7925.txt
Patch attached.
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169753#comment-13169753 ]
Todd Lipcon commented on HADOOP-7925:
-------------------------------------
Does the new test pass? It calls -getState but the new command is -getServiceState. If it does pass there's something wrong with our test harness :)
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172238#comment-13172238 ]
Hudson commented on HADOOP-7925:
--------------------------------
Integrated in Hadoop-Hdfs-HAbranch-build #21 (See [https://builds.apache.org/job/Hadoop-Hdfs-HAbranch-build/21/])
HADOOP-7925. Add interface and update CLI to query current state to HAServiceProtocol. Contributed by Eli Collins.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1220611
Files :
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/CHANGES.HDFS-1623.txt
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAAdmin.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/HAServiceProtocol.java
* /hadoop/common/branches/HDFS-1623/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestHAAdmin.java
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: HA Branch (HDFS-1623)
>
> Attachments: hadoop-7925.txt, hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7925:
--------------------------------
Attachment: hadoop-7925.txt
Doh! Updated patch.
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7925:
--------------------------------
Attachment: hadoop-7925.txt
Uma, good suggestion. Updated patch attached.
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt, hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7925) Add interface and update CLI to
query current state to HAServiceProtocol
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171701#comment-13171701 ]
Uma Maheswara Rao G commented on HADOOP-7925:
---------------------------------------------
+1, lgtm
> Add interface and update CLI to query current state to HAServiceProtocol
> ------------------------------------------------------------------------
>
> Key: HADOOP-7925
> URL: https://issues.apache.org/jira/browse/HADOOP-7925
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Eli Collins
> Assignee: Eli Collins
> Attachments: hadoop-7925.txt, hadoop-7925.txt, hadoop-7925.txt
>
>
> Common side of HDFS-2679.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira