[GitHub] [jmeter] vlsi commented on a change in pull request #669: 65461: support multiple keys in the client keystore (select the matching one by keyType)

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #669:
URL: https://github.com/apache/jmeter/pull/669#discussion_r775909820



##########
File path: src/core/src/main/java/org/apache/jmeter/util/keystore/JmeterKeyStore.java
##########
@@ -303,36 +323,60 @@ private boolean isIndexInConfiguredRange(int index) {
      * @throws IllegalArgumentException if {@link #clientCertAliasVarName}
      *                                  is not empty and no key for this alias could be found
      */
-    public String getAlias() {
+    public String getAlias(String [] keyTypes) {

Review comment:
       this class should be removed though. I don't think it adds value :-/




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org