[GitHub] [ozone] jojochuang commented on a diff in pull request #4443: HDDS-7098. Provide a way for admin to identify all unhealthy container replicas

["jojochuang (via GitHub)" <gi...@apache.org>]

jojochuang commented on code in PR #4443:
URL: https://github.com/apache/ozone/pull/4443#discussion_r1156466572


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -405,6 +405,7 @@ message ContainerReplicaHistoryProto {
     required int64 firstSeenTime = 2;
     required int64 lastSeenTime = 3;
     required int64 bcsId = 4;
+    required string state = 5;

Review Comment:
   It would break rolling upgrade, or when recon and SCM are in different versions.
   
   I see that rolling upgrade is not yet a thing, so I am okay with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org