You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "tenthe (via GitHub)" <gi...@apache.org> on 2026/09/24 13:51:15 UTC

[PR] feat: make NATS the default broker in core and e2e

tenthe opened a new pull request, #5029:
URL: https://github.com/apache/streampipes/pull/5029

   <!--
     ~ Licensed to the Apache Software Foundation (ASF) under one or more
     ~ contributor license agreements.  See the NOTICE file distributed with
     ~ this work for additional information regarding copyright ownership.
     ~ The ASF licenses this file to You under the Apache License, Version 2.0
     ~ (the "License"); you may not use this file except in compliance with
     ~ the License.  You may obtain a copy of the License at
     ~
     ~    http://www.apache.org/licenses/LICENSE-2.0
     ~
     ~ Unless required by applicable law or agreed to in writing, software
     ~ distributed under the License is distributed on an "AS IS" BASIS,
     ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
     ~ See the License for the specific language governing permissions and
     ~ limitations under the License.
     ~
     -->
   
     <!--
   Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
   1. If this is your first time, please read our contributor guidelines:
       - https://streampipes.apache.org/community/get-involved/
       - https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
   2. Make sure the PR title is formatted like: `[#<GitHub issue id>] PR title ...`
   3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][#<GitHub issue id>] PR title ...`.
   4. Please write your PR title to summarize what this PR proposes/fixes.
   5. Link the PR to the corresponding GitHub issue (if present) in the `Development` section in the right menu bar.
   6. Be sure to keep the PR description updated to reflect all changes.
   7. If possible, provide a concise example to reproduce the issue for a faster review.
   8. Make sure tests pass via `mvn clean install`.
   9. (Optional) If the contribution is large, please file an Apache ICLA
       - http://apache.org/licenses/icla.pdf
   -->
   
   ### Purpose
   <!--
   Please clarify what changes you are proposing and describe how those changes will address the issue.
   Furthermore, describe potential consequences the changes might have.
   -->
   
   This PR completes the switch from Kafka to NATS as the default message broker. The documented deployments (compose installer, Helm chart, dev container) already default to NATS, but the compiled fallback in the backend and the client end-to-end test stacks still ran against Kafka. Both are now aligned with NATS.
   
   ### Changes
   
     - Changes the compiled default of SP_PRIORITIZED_PROTOCOL from kafka to nats, so a backend started without the variable now selects NATS.
     - Pins the backend in the single-instance client e2e stack to NATS instead of Kafka.
     - Sets NATS explicitly in the load-balance client e2e stack, which previously inherited the compiled Kafka default.
     - Removes the now-unused Kafka service and its volume from both e2e compose files. The Java tests already ground their adapter, streams and sink on NATS, so no test depended on Kafka.
   
   
   ### Remarks
   <!--
   Is there anything left we need to pay attention on?
   Are there some references that might be important? E.g. links to Confluence, or discussions
   on the mailing list or GitHub.
   -->
   PR introduces (a) breaking change(s): no
   
   PR introduces (a) deprecation(s): no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: make NATS the default broker in core and e2e

Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on PR #5029:
URL: https://github.com/apache/streampipes/pull/5029#issuecomment-5834194325

   We should mention in the release notes that users with a Kafka installation must now explicitly set SP_PRIORITIZED_PROTOCOL when upgrading


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: make NATS the default broker in core and e2e

Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe merged PR #5029:
URL: https://github.com/apache/streampipes/pull/5029


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org