You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/04/18 13:15:16 UTC
Review Request 46318: Added helper to create test slave with injected
`Authorizer`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
Bugs: MESOS-5164
https://issues.apache.org/jira/browse/MESOS-5164
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
Diff: https://reviews.apache.org/r/46318/diff/
Testing
-------
make check (OS X, clang w/o optimization)
Thanks,
Benjamin Bannier
Re: Review Request 46318: Added helper to create test agent with
injected `Authorizer`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On April 22, 2016, 9:42 a.m., Adam B wrote:
> > src/tests/mesos.hpp, line 210
> > <https://reviews.apache.org/r/46318/diff/1/?file=1348100#file1348100line210>
> >
> > How do you know this is the set of parameters your helper will need? Why don't you need a containerizer, etc.?
The general pattern for the existing `MesosTest::StartSlave` overloads seems to be to allow injecting just one specific aspect; if a user needs to inject more she would call `cluster::Slave::start` directly. The added overload tries to follow that spirit.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130053
-----------------------------------------------------------
On April 22, 2016, 4:04 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
>
> (Updated April 22, 2016, 4:04 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
>
>
> Bugs: MESOS-5164
> https://issues.apache.org/jira/browse/MESOS-5164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In addition to the fully generic interface we do provide a number of
> short hand functions for creating agents in tests which allow injecting
> just a single component. Add one such short hand function for creating
> a test agent with an injected `Authorizer` which we will use in a
> subsequent patch.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
> src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
>
> Diff: https://reviews.apache.org/r/46318/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang w/o optimization)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46318: Added helper to create test slave with
injected `Authorizer`.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130053
-----------------------------------------------------------
Please add a bit more motivation to the description, especially if it's a precursor patch that I'd review before getting to the meat where it's actually used. While this patch would compile if committed on its own, it seems useless/pointless without something calling the new method.
src/tests/mesos.hpp (line 210)
<https://reviews.apache.org/r/46318/#comment193672>
How do you know this is the set of parameters your helper will need? Why don't you need a containerizer, etc.?
- Adam B
On April 18, 2016, 4:15 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 4:15 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
>
>
> Bugs: MESOS-5164
> https://issues.apache.org/jira/browse/MESOS-5164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
> src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
>
> Diff: https://reviews.apache.org/r/46318/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang w/o optimization)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46318: Added helper to create test agent with
injected `Authorizer`.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130383
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 25, 2016, 10:19 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 10:19 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
>
>
> Bugs: MESOS-5164
> https://issues.apache.org/jira/browse/MESOS-5164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In addition to the fully generic interface we do provide a number of
> short hand functions for creating agents in tests which allow injecting
> just a single component. Add one such short hand function for creating
> a test agent with an injected `Authorizer` which we will use in a
> subsequent patch.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
> src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
>
> Diff: https://reviews.apache.org/r/46318/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang w/o optimization)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46318: Added helper to create test agent with
injected `Authorizer`.
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review130386
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On April 25, 2016, 1:19 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
>
> (Updated April 25, 2016, 1:19 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
>
>
> Bugs: MESOS-5164
> https://issues.apache.org/jira/browse/MESOS-5164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In addition to the fully generic interface we do provide a number of
> short hand functions for creating agents in tests which allow injecting
> just a single component. Add one such short hand function for creating
> a test agent with an injected `Authorizer` which we will use in a
> subsequent patch.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
> src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
>
> Diff: https://reviews.apache.org/r/46318/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang w/o optimization)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 46318: Added helper to create test agent with
injected `Authorizer`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/
-----------------------------------------------------------
(Updated April 25, 2016, 10:19 a.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
Changes
-------
Reorder deps on Jan's request.
Bugs: MESOS-5164
https://issues.apache.org/jira/browse/MESOS-5164
Repository: mesos
Description
-------
In addition to the fully generic interface we do provide a number of
short hand functions for creating agents in tests which allow injecting
just a single component. Add one such short hand function for creating
a test agent with an injected `Authorizer` which we will use in a
subsequent patch.
Diffs
-----
src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
Diff: https://reviews.apache.org/r/46318/diff/
Testing
-------
make check (OS X, clang w/o optimization)
Thanks,
Benjamin Bannier
Re: Review Request 46318: Added helper to create test agent with
injected `Authorizer`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/
-----------------------------------------------------------
(Updated April 22, 2016, 4:04 p.m.)
Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
Summary (updated)
-----------------
Added helper to create test agent with injected `Authorizer`.
Bugs: MESOS-5164
https://issues.apache.org/jira/browse/MESOS-5164
Repository: mesos
Description (updated)
-------
In addition to the fully generic interface we do provide a number of
short hand functions for creating agents in tests which allow injecting
just a single component. Add one such short hand function for creating
a test agent with an injected `Authorizer` which we will use in a
subsequent patch.
Diffs (updated)
-----
src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
Diff: https://reviews.apache.org/r/46318/diff/
Testing
-------
make check (OS X, clang w/o optimization)
Thanks,
Benjamin Bannier
Re: Review Request 46318: Added helper to create test slave with
injected `Authorizer`.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46318/#review129330
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On April 18, 2016, 1:15 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46318/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 1:15 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht.
>
>
> Bugs: MESOS-5164
> https://issues.apache.org/jira/browse/MESOS-5164
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/mesos.hpp e4b63d41d883807ac39846799468b80e88c84e0b
> src/tests/mesos.cpp b5937af7713e1ee2af475518b3e968b2defa8beb
>
> Diff: https://reviews.apache.org/r/46318/diff/
>
>
> Testing
> -------
>
> make check (OS X, clang w/o optimization)
>
>
> Thanks,
>
> Benjamin Bannier
>
>