You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/24 10:50:42 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #4358: Do not log error if page index can not be evaluatied
alamb opened a new pull request, #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/4236 (cc @HaoYang670 )
# Rationale for this change
errors are ignored when creating page indexes but were being logged as error (to the output)
# What changes are included in this PR?
reduce logging level to debug from error
# Are these changes tested?
No (for logging)
# Are there any user-facing changes?
Not really. cc @Ted-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #4358: Do not log error if page index can not be evaluatied
Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1326974073
@alamb this change to good to me! But i still have a question about when to use `error!` in datafusion 🤔? after https://github.com/apache/arrow-datafusion/commit/d7a7fb61afe9ce2824aae737f65aec12d9513f7f merged i think there should no error log in test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4358: Do not log error if page index can not be evaluated
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1328041763
I think this is a reasonable change even though the specific error in datafusion was previously fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4358: Do not log error if page index can not be evaluated
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1328042412
Benchmark runs are scheduled for baseline = 24453f988cb0e4b6f0d53723634dcf358afa7594 and contender = 120689c22e97cd7c2a33ba08c7cc0e30de7af417. 120689c22e97cd7c2a33ba08c7cc0e30de7af417 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7ac7be455d2b4b3b8ea21601a21b326d...2ba7635d2d954ba09b62f9814799b8c4/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/18cccf3df86e4eeaa1a2ee1baa06094d...2409bfb338684d068d82a43fe999c761/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/75e81026b74a4b728cbf4e4a0bd7138e...eb34c4ae4f8c417cbc6dbeec22652fcd/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c4ddea0b5fbf483b8de38b20ba0e1c78...4aab21a1b8814cf2b9a85f687c45e90d/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4358: Do not log error if page index can not be evaluated
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #4358: Do not log error if page index can not be evaluated
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1328041650
> @alamb this change to good to me! But i still have a question about when to use error! in datafusion 🤔?
I like the "I generally subscribe to the following convention:" answer from this;
https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels
So only log errors when there is something a system adminstrator should look at / look into. If they can't do anything about it it probably shouldn't be an error (more like a warn! if it means a DataFusion bug or debug if more like an FYI)
> after https://github.com/apache/arrow-datafusion/commit/d7a7fb61afe9ce2824aae737f65aec12d9513f7f merged i think there should no error log in test.
Awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] HaoYang670 commented on pull request #4358: Do not log error if page index can not be evaluatied
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on PR #4358:
URL: https://github.com/apache/arrow-datafusion/pull/4358#issuecomment-1326942242
Thank you, @alamb !
I am OK with the change. But I re-ran the test `filter_pushdown::single_file` on the master branch and there is no error reported now. Not sure if this has been fixed by https://github.com/apache/arrow-datafusion/pull/4255.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org