You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by antonio <an...@vieiro.net> on 2022/01/01 10:40:19 UTC
cnd-small proposal
Hi all,
Here is a proposal to integrate a subset of cnd in Apache NetBeans
https://cwiki.apache.org/confluence/display/NETBEANS/cnd+integration+proposal%3A+cnd-small
Comments/reviews are welcome.
Happy 2022!,
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: cnd-small proposal
Posted by Michael Bien <mb...@gmail.com>.
i haven't found the time yet but i was planning to try to move the shell
and batch file editors from the old c++ cluster to the main language
cluster (side by side to yaml support and similar modules).
The modules look on first glance fairly independent and i think if the
make file support can be removed they could be easily integrated.
best regards,
-michael
On 01.01.22 11:40, antonio wrote:
> Hi all,
>
> Here is a proposal to integrate a subset of cnd in Apache NetBeans
> https://cwiki.apache.org/confluence/display/NETBEANS/cnd+integration+proposal%3A+cnd-small
>
>
> Comments/reviews are welcome.
>
> Happy 2022!,
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: cnd-small proposal
Posted by Geertjan Wielenga <ge...@googlemail.com.INVALID>.
Wow, looks cool. :-)
Gj
On Sat, Jan 1, 2022 at 11:40 AM antonio <an...@vieiro.net> wrote:
> Hi all,
>
> Here is a proposal to integrate a subset of cnd in Apache NetBeans
>
> https://cwiki.apache.org/confluence/display/NETBEANS/cnd+integration+proposal%3A+cnd-small
>
> Comments/reviews are welcome.
>
> Happy 2022!,
> Antonio
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>
Re: cnd-small proposal
Posted by antonio <an...@vieiro.net>.
Yep. Let's get the rest working first :-).
Kind regards,
Antonio
El 2/1/22 a las 21:38, Matthias Bläsing escribió:
> While a unified approach might be helpful, I would not put too much
> focus on that and first focus on getting the rest working. To me this
> sounds like polishing.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: cnd-small proposal
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi,
Am Sonntag, dem 02.01.2022 um 10:59 +0100 schrieb antonio:
> >
> > I'm not sure about the comment for cnd-small/3:
> >
> > The cpplite.editor indeed builds on top of the lsp.client module. The
> > class org.netbeans.modules.cpplite.editor.lsp.LanguageServerImpl is the
> > binding between the configuration, that the cpplite.editor module
> > provides and the LSP API, that is provided by lsp.client. If I read the
> > code correctly, ccls is used, if configured and switches over to clangd
> > else.
>
> Yep. I have to rephrase that. cpplite does indeed use lsp.client. The
> user interface is somehow duplicated, though:
>
> - lsp.client has a panel (Editors/Language Servers) in the Options Panel
> where language servers are registered.
>
> - cpplite has instead a C/C++ top-level tab in the Options Panel, where
> it automatically checks for ccls and clangd in the PATH. That's very
> handy. But not clangd nor ccls are registered in the panel in lsp.client.
in my mind, this is not that bad. The LSP specific dialog is for
servers without direct support in NetBeans. C/C++ support is different
in, that it directly supports two different LSP servers. Consider
TypeScript in that case we even carry the whole infrastructure (apart
from the node runtime).
While a unified approach might be helpful, I would not put too much
focus on that and first focus on getting the rest working. To me this
sounds like polishing.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: cnd-small proposal
Posted by antonio <an...@vieiro.net>.
Hi Matthias,
Some comments inlined below.
El 2/1/22 a las 10:42, Matthias Bläsing escribió:
> Hi Antonio,
>
> Am Samstag, dem 01.01.2022 um 11:40 +0100 schrieb antonio:
>>
>> Here is a proposal to integrate a subset of cnd in Apache NetBeans
>> https://cwiki.apache.org/confluence/display/NETBEANS/cnd+integration+proposal%3A+cnd-small
>>
>> Comments/reviews are welcome.
>
> I had a first look at cnd-small. If I read this correctly this is based
> on the CND branch, where Jan imported the 4+5 donation zip. This sounds
> sane.
>
> For this branch I have only one comment:
>
> 5c7ade6e6a2685f8cb8777a5b42bc656fced7576 [cnd] Removed non-project related modules
>
> I would not remove the modules, but move them to the "contrib"
> directory. That way we don't loose track of the files in the git
> history (direct renames should be trackable) and the already happend
> license cleanup. If then a module is to be resurrected, it is a move
> (first) commit and then some "enabling" commits. We then don't have to
> reevaluate where "all these new files" come from.
+1. Very good idea.
>
>
> I'm not sure about the comment for cnd-small/3:
>
> The cpplite.editor indeed builds on top of the lsp.client module. The
> class org.netbeans.modules.cpplite.editor.lsp.LanguageServerImpl is the
> binding between the configuration, that the cpplite.editor module
> provides and the LSP API, that is provided by lsp.client. If I read the
> code correctly, ccls is used, if configured and switches over to clangd
> else.
Yep. I have to rephrase that. cpplite does indeed use lsp.client. The
user interface is somehow duplicated, though:
- lsp.client has a panel (Editors/Language Servers) in the Options Panel
where language servers are registered.
- cpplite has instead a C/C++ top-level tab in the Options Panel, where
it automatically checks for ccls and clangd in the PATH. That's very
handy. But not clangd nor ccls are registered in the panel in lsp.client.
>
>
> In general you seem to have a plan and cut it down, so that it is
> manageable. If you need help, feel free to ask. Even gettings parts of
> CND into mainline again will help and improve the situation. What is
> more it will send the right message: There is development going on and
> maybe people will join in instead of complaining :-)
+1. I'll ask for help as required.
Thank you,
Antonio
>
> Thank you
>
> Matthias
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: cnd-small proposal
Posted by Matthias Bläsing <mb...@doppel-helix.eu>.
Hi Antonio,
Am Samstag, dem 01.01.2022 um 11:40 +0100 schrieb antonio:
>
> Here is a proposal to integrate a subset of cnd in Apache NetBeans
> https://cwiki.apache.org/confluence/display/NETBEANS/cnd+integration+proposal%3A+cnd-small
>
> Comments/reviews are welcome.
I had a first look at cnd-small. If I read this correctly this is based
on the CND branch, where Jan imported the 4+5 donation zip. This sounds
sane.
For this branch I have only one comment:
5c7ade6e6a2685f8cb8777a5b42bc656fced7576 [cnd] Removed non-project related modules
I would not remove the modules, but move them to the "contrib"
directory. That way we don't loose track of the files in the git
history (direct renames should be trackable) and the already happend
license cleanup. If then a module is to be resurrected, it is a move
(first) commit and then some "enabling" commits. We then don't have to
reevaluate where "all these new files" come from.
I'm not sure about the comment for cnd-small/3:
The cpplite.editor indeed builds on top of the lsp.client module. The
class org.netbeans.modules.cpplite.editor.lsp.LanguageServerImpl is the
binding between the configuration, that the cpplite.editor module
provides and the LSP API, that is provided by lsp.client. If I read the
code correctly, ccls is used, if configured and switches over to clangd
else.
In general you seem to have a plan and cut it down, so that it is
manageable. If you need help, feel free to ask. Even gettings parts of
CND into mainline again will help and improve the situation. What is
more it will send the right message: There is development going on and
maybe people will join in instead of complaining :-)
Thank you
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
For additional commands, e-mail: dev-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists