[GitHub] [airflow] feluelle commented on a change in pull request #11113: Adding GreatExpectationsBigQueryOperator

[GitBox <gi...@apache.org>]

feluelle commented on a change in pull request #11113:
URL: https://github.com/apache/airflow/pull/11113#discussion_r504412978



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -20,26 +20,39 @@
 """
 This module contains Google BigQuery operators.
 """
+import datetime
 import enum
 import hashlib
 import json
+import logging
+import random
 import re
+import string
 import uuid
 import warnings
+import uuid
 from typing import Any, Dict, Iterable, List, Optional, Sequence, Set, SupportsAbs, Union
+from urllib.parse import urlsplit
 
 import attr
 from google.api_core.exceptions import Conflict
 from google.cloud.bigquery import TableReference
 
+from airflow.providers.greatexpectations.operators.greatexpectations_base import GreatExpectationsBaseOperator
+from great_expectations.data_context.types.base import DataContextConfig
+from great_expectations.data_context import BaseDataContext

Review comment:
       +1 for moving all `great_expectations` imports to its provider package.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org