[GitHub] dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account

[GitBox <gi...@apache.org>]

dhlaluku commented on a change in pull request #3058: CLOUDSTACK-3049: update dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#discussion_r248004026
 
 

 ##########
 File path: server/src/main/java/com/cloud/user/AccountManagerImpl.java
 ##########
 @@ -1687,6 +1692,7 @@ public AccountVO disableAccount(String accountName, Long domainId, Long accountI
     public AccountVO updateAccount(UpdateAccountCmd cmd) {
         Long accountId = cmd.getId();
         Long domainId = cmd.getDomainId();
+        Long roleId = cmd.getRoleId();
         String accountName = cmd.getAccountName();
         String newAccountName = cmd.getNewName();
         String networkDomain = cmd.getNetworkDomain();
 
 Review comment:
   @bwsw while we are here, I have just realized that 'cmd.getDetails' might throw an NPE. Could you please add an NPE check for this call?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services