You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2015/10/15 20:38:21 UTC

incubator-reef git commit: [REEF-850] Delete or suppress verbose outputs in Unit Tests

Repository: incubator-reef
Updated Branches:
  refs/heads/master 16cb0009a -> 7080e129d


[REEF-850] Delete or suppress verbose outputs in Unit Tests

This addresses the following issues:
  * Delete println() from TestCombiner
  * Replace Level.INFO with Level.FINE in HostnameBasedLocalAddressProvider constructor
  * Replace Level.INFO with Level.FINE in LegacyLocalAddressProvider constructor

JIRA:
  [REEF-850](https://issues.apache.org/jira/browse/REEF-850)

Pull Request:
  This closes #568


Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/7080e129
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/7080e129
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/7080e129

Branch: refs/heads/master
Commit: 7080e129d4c6aea51fabcae04af5ab137b3dee3d
Parents: 16cb000
Author: Dongjoon Hyun <do...@apache.org>
Authored: Thu Oct 15 14:49:21 2015 +0900
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Thu Oct 15 11:36:55 2015 -0700

----------------------------------------------------------------------
 .../wake/remote/address/HostnameBasedLocalAddressProvider.java     | 2 +-
 .../reef/wake/remote/address/LegacyLocalAddressProvider.java       | 2 +-
 .../test/java/org/apache/reef/wake/test/examples/TestCombiner.java | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/7080e129/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
index d8789c2..0247a7c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/HostnameBasedLocalAddressProvider.java
@@ -39,7 +39,7 @@ public final class HostnameBasedLocalAddressProvider implements LocalAddressProv
    */
   @Inject
   private HostnameBasedLocalAddressProvider() {
-    LOG.log(Level.INFO, "Instantiating HostnameBasedLocalAddressProvider");
+    LOG.log(Level.FINE, "Instantiating HostnameBasedLocalAddressProvider");
   }
 
   @Override

http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/7080e129/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
index 00a38e6..68ef3b4 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/address/LegacyLocalAddressProvider.java
@@ -46,7 +46,7 @@ public final class LegacyLocalAddressProvider implements LocalAddressProvider {
    */
   @Inject
   private LegacyLocalAddressProvider() {
-    LOG.log(Level.INFO, "Instantiating LegacyLocalAddressProvider");
+    LOG.log(Level.FINE, "Instantiating LegacyLocalAddressProvider");
   }
 
   @Override

http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/7080e129/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
index dc82307..1034e03 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/TestCombiner.java
@@ -57,7 +57,6 @@ public class TestCombiner {
 
           @Override
           public void onNext(final Entry<Integer, Integer> value) {
-            System.out.println(value.getKey() + "=" + value.getValue());
             x.incrementAndGet();
             try {
               if (!done) {