You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/01/29 09:54:50 UTC
[GitHub] [incubator-pegasus] Smityz opened a new pull request #899: fix(build): update GCC and CMake checker
Smityz opened a new pull request #899:
URL: https://github.com/apache/incubator-pegasus/pull/899
Related issue:
https://github.com/apache/incubator-pegasus/issues/898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on a change in pull request #899: fix(build): update GCC and CMake checker
Posted by GitBox <gi...@apache.org>.
neverchanje commented on a change in pull request #899:
URL: https://github.com/apache/incubator-pegasus/pull/899#discussion_r805519292
##########
File path: src/CMakeLists.txt
##########
@@ -15,7 +15,14 @@
# specific language governing permissions and limitations
# under the License.
-cmake_minimum_required(VERSION 3.5.2)
+cmake_minimum_required(VERSION 3.11.0)
+
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+ # require at least gcc 5.4.0
+ if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.4.0)
Review comment:
you guys can be more aggressive to allow only gcc7 actually, since you have bundled gcc already.
Higher gcc version doesn't mean less adoption you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #899: fix(build): update GCC and CMake checker
Posted by GitBox <gi...@apache.org>.
acelyc111 merged pull request #899:
URL: https://github.com/apache/incubator-pegasus/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] neverchanje commented on a change in pull request #899: fix(build): update GCC and CMake checker
Posted by GitBox <gi...@apache.org>.
neverchanje commented on a change in pull request #899:
URL: https://github.com/apache/incubator-pegasus/pull/899#discussion_r805519292
##########
File path: src/CMakeLists.txt
##########
@@ -15,7 +15,14 @@
# specific language governing permissions and limitations
# under the License.
-cmake_minimum_required(VERSION 3.5.2)
+cmake_minimum_required(VERSION 3.11.0)
+
+if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+ # require at least gcc 5.4.0
+ if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.4.0)
Review comment:
you guys can be more aggressive to allow only gcc7 actually, since you have bundled gcc already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #899: fix(build): update GCC and CMake checker
Posted by GitBox <gi...@apache.org>.
acelyc111 merged pull request #899:
URL: https://github.com/apache/incubator-pegasus/pull/899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org