You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2020/05/04 21:22:52 UTC
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15858
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
This is needed for python3 compatibility.
Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M shell/.gitignore
D shell/ext-py/bitarray-0.9.0/PKG-INFO
D shell/ext-py/bitarray-0.9.0/bitarray/__init__.py
A shell/ext-py/bitarray-1.2.1/AUTHORS
A shell/ext-py/bitarray-1.2.1/CHANGE_LOG
A shell/ext-py/bitarray-1.2.1/LICENSE
A shell/ext-py/bitarray-1.2.1/README.md
A shell/ext-py/bitarray-1.2.1/TODO
A shell/ext-py/bitarray-1.2.1/bitarray/__init__.py
R shell/ext-py/bitarray-1.2.1/bitarray/_bitarray.c
A shell/ext-py/bitarray-1.2.1/bitarray/_util.c
R shell/ext-py/bitarray-1.2.1/bitarray/test_bitarray.py
A shell/ext-py/bitarray-1.2.1/bitarray/test_util.py
A shell/ext-py/bitarray-1.2.1/bitarray/util.py
R shell/ext-py/bitarray-1.2.1/setup.py
A shell/ext-py/bitarray-1.2.1/update_readme.py
M shell/packaging/requirements.txt
19 files changed, 3,650 insertions(+), 1,426 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/15858/1
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 07:17:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 12:33:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5740/
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 01:21:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 1:
> Patch Set 1: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5740/
I think this failure is unrelated. This seems to be caused by IMPALA-1995.
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 01:26:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
This is needed for python3 compatibility.
Tested by running gerrit-verify-dryrun.
Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Reviewed-on: http://gerrit.cloudera.org:8080/15858
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M shell/.gitignore
D shell/ext-py/bitarray-0.9.0/PKG-INFO
D shell/ext-py/bitarray-0.9.0/bitarray/__init__.py
A shell/ext-py/bitarray-1.2.1/AUTHORS
A shell/ext-py/bitarray-1.2.1/CHANGE_LOG
A shell/ext-py/bitarray-1.2.1/LICENSE
A shell/ext-py/bitarray-1.2.1/README.md
A shell/ext-py/bitarray-1.2.1/TODO
A shell/ext-py/bitarray-1.2.1/bitarray/__init__.py
R shell/ext-py/bitarray-1.2.1/bitarray/_bitarray.c
A shell/ext-py/bitarray-1.2.1/bitarray/_util.c
R shell/ext-py/bitarray-1.2.1/bitarray/test_bitarray.py
A shell/ext-py/bitarray-1.2.1/bitarray/test_util.py
A shell/ext-py/bitarray-1.2.1/bitarray/util.py
R shell/ext-py/bitarray-1.2.1/setup.py
A shell/ext-py/bitarray-1.2.1/update_readme.py
M shell/packaging/requirements.txt
19 files changed, 3,650 insertions(+), 1,426 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 2: Code-Review+2
Checked out the bitarray 1.2.1 release tag and did a diff -r to confirm the contents are identical
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 05:16:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5950/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 May 2020 22:06:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15858
to look at the new patch set (#2).
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
This is needed for python3 compatibility.
Tested by running gerrit-verify-dryrun.
Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
---
M LICENSE.txt
M bin/rat_exclude_files.txt
M shell/.gitignore
D shell/ext-py/bitarray-0.9.0/PKG-INFO
D shell/ext-py/bitarray-0.9.0/bitarray/__init__.py
A shell/ext-py/bitarray-1.2.1/AUTHORS
A shell/ext-py/bitarray-1.2.1/CHANGE_LOG
A shell/ext-py/bitarray-1.2.1/LICENSE
A shell/ext-py/bitarray-1.2.1/README.md
A shell/ext-py/bitarray-1.2.1/TODO
A shell/ext-py/bitarray-1.2.1/bitarray/__init__.py
R shell/ext-py/bitarray-1.2.1/bitarray/_bitarray.c
A shell/ext-py/bitarray-1.2.1/bitarray/_util.c
R shell/ext-py/bitarray-1.2.1/bitarray/test_bitarray.py
A shell/ext-py/bitarray-1.2.1/bitarray/test_util.py
A shell/ext-py/bitarray-1.2.1/bitarray/util.py
R shell/ext-py/bitarray-1.2.1/setup.py
A shell/ext-py/bitarray-1.2.1/update_readme.py
M shell/packaging/requirements.txt
19 files changed, 3,650 insertions(+), 1,426 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/15858/2
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15858 )
Change subject: IMPALA-9720: Update bitarray 0.9.0 -> 1.2.1
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5749/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0641b03e880314a424d9d5a0651945c4f51273bc
Gerrit-Change-Number: 15858
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 May 2020 07:17:51 +0000
Gerrit-HasComments: No