You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by bl...@apache.org on 2022/02/06 18:27:01 UTC

[iceberg] branch master updated: Spark 3.2: Remove unused methods in SparkScanBuilder (#4043)

This is an automated email from the ASF dual-hosted git repository.

blue pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 2ddd0be  Spark 3.2: Remove unused methods in SparkScanBuilder (#4043)
2ddd0be is described below

commit 2ddd0bec6d3736664c56f6fdb00b523f793c4843
Author: Anton Okolnychyi <ao...@apple.com>
AuthorDate: Sun Feb 6 10:26:53 2022 -0800

    Spark 3.2: Remove unused methods in SparkScanBuilder (#4043)
---
 .../java/org/apache/iceberg/spark/source/SparkScanBuilder.java   | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java b/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
index 7b5feb0..30c033f 100644
--- a/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
+++ b/spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java
@@ -19,7 +19,6 @@
 
 package org.apache.iceberg.spark.source;
 
-import java.util.Collections;
 import java.util.List;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
@@ -62,7 +61,6 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
   private final List<String> metaColumns = Lists.newArrayList();
 
   private Schema schema = null;
-  private StructType requestedProjection;
   private boolean caseSensitive;
   private List<Expression> filterExpressions = null;
   private Filter[] pushedFilters = NO_FILTERS;
@@ -87,11 +85,6 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
     return Expressions.alwaysTrue();
   }
 
-  public SparkScanBuilder withMetadataColumns(String... metadataColumns) {
-    Collections.addAll(metaColumns, metadataColumns);
-    return this;
-  }
-
   public SparkScanBuilder caseSensitive(boolean isCaseSensitive) {
     this.caseSensitive = isCaseSensitive;
     return this;
@@ -130,7 +123,7 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
 
   @Override
   public void pruneColumns(StructType requestedSchema) {
-    this.requestedProjection = new StructType(Stream.of(requestedSchema.fields())
+    StructType requestedProjection = new StructType(Stream.of(requestedSchema.fields())
         .filter(field -> MetadataColumns.nonMetadataColumn(field.name()))
         .toArray(StructField[]::new));