You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Jayapal Reddy <ja...@citrix.com> on 2013/06/11 16:37:08 UTC

Review Request: fixed not showing uuid of ip address id and network in list firewall and list egress firewall rules response

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11803/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

showing uuid of ip address id in list firewall rules response
showing uuid of network id of in list egress firewall rules response


This addresses bug cloudstack-2934.


Diffs
-----

  api/src/org/apache/cloudstack/api/response/FirewallResponse.java 26d2433 
  server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 

Diff: https://reviews.apache.org/r/11803/diff/


Testing
-------

Tested listFirewallRules and listEgressFirewallRules API responses


Thanks,

Jayapal Reddy


Re: Review Request: fixed not showing uuid of ip address id and network in list firewall and list egress firewall rules response

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11803/#review21846
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On June 12, 2013, 9:46 a.m., Jayapal Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11803/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 9:46 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Murali Reddy.
> 
> 
> Description
> -------
> 
> showing uuid of ip address id in list firewall rules response
> showing uuid of network id of in list egress firewall rules response
> 
> 
> This addresses bug cloudstack-2934.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/response/FirewallResponse.java 26d2433 
>   server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 
> 
> Diff: https://reviews.apache.org/r/11803/diff/
> 
> 
> Testing
> -------
> 
> Tested listFirewallRules and listEgressFirewallRules API responses
> 
> 
> Thanks,
> 
> Jayapal Reddy
> 
>


Re: Review Request: fixed not showing uuid of ip address id and network in list firewall and list egress firewall rules response

Posted by Jayapal Reddy <ja...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11803/
-----------------------------------------------------------

(Updated June 12, 2013, 9:46 a.m.)


Review request for cloudstack, Abhinandan Prateek and Murali Reddy.


Description
-------

showing uuid of ip address id in list firewall rules response
showing uuid of network id of in list egress firewall rules response


This addresses bug cloudstack-2934.


Diffs
-----

  api/src/org/apache/cloudstack/api/response/FirewallResponse.java 26d2433 
  server/src/com/cloud/api/ApiResponseHelper.java 0c98abc 

Diff: https://reviews.apache.org/r/11803/diff/


Testing
-------

Tested listFirewallRules and listEgressFirewallRules API responses


Thanks,

Jayapal Reddy