[GitHub] michellethomas opened a new pull request #5100: Fix form data issue switching viz types

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #5100: Fix form data issue switching viz types
URL: https://github.com/apache/incubator-superset/pull/5100
 
 
   We've been having an issue with extra params getting into the form data (that are not valid controls for a particular viz type), this breaks the query and there's no way to remove it from the controls. This happens when you switch from a time series with a group by to a big number. The group by in the rawFormData will get added to the form_data and create a query that's invalid for a big number chart (that doesn't have a group by control).
   
   It looks like this was introduced [here](https://github.com/apache/incubator-superset/pull/4578/files) so I'm assuming that the only extra form data param is our url params section. If this is not true let me know.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org