You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Michael Singer (JIRA)" <ji...@apache.org> on 2006/02/01 12:01:03 UTC
[jira] Created: (JCR-311) Unnecessary parameter in
NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
Unnecessary parameter in NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
-------------------------------------------------------------------------------------------
Key: JCR-311
URL: http://issues.apache.org/jira/browse/JCR-311
Project: Jackrabbit
Type: Task
Components: nodetype
Reporter: Michael Singer
Priority: Trivial
The parameter "store" is not used within this method. I suggest to delete the parameter to make the code more readable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-311) Unnecessary parameter in
NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
Posted by "Michael Singer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-311?page=all ]
Michael Singer updated JCR-311:
-------------------------------
Attachment: patch.txt
This patch removes the parameter "store" from method persistCustomNodeTypeDefs in class NodeTypeRegistry and in calls to this method (from within the class)
> Unnecessary parameter in NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
> -------------------------------------------------------------------------------------------
>
> Key: JCR-311
> URL: http://issues.apache.org/jira/browse/JCR-311
> Project: Jackrabbit
> Type: Task
> Components: nodetype
> Reporter: Michael Singer
> Priority: Trivial
> Attachments: patch.txt
>
> The parameter "store" is not used within this method. I suggest to delete the parameter to make the code more readable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (JCR-311) Unnecessary parameter in
NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-311?page=all ]
Stefan Guggisberg closed JCR-311:
---------------------------------
Resolution: Fixed
NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
is protected, i.e. it might be used by subclasses.
rather than removing the 'store' parameter i changed the implementation to that effect that it now makes use of it.
> Unnecessary parameter in NodeTypeRegistry.persistCustomNodeTypeDefs(NodeTypeDefStore store)
> -------------------------------------------------------------------------------------------
>
> Key: JCR-311
> URL: http://issues.apache.org/jira/browse/JCR-311
> Project: Jackrabbit
> Type: Task
> Components: nodetype
> Reporter: Michael Singer
> Priority: Trivial
> Attachments: patch.txt
>
> The parameter "store" is not used within this method. I suggest to delete the parameter to make the code more readable.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira