[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #20: [FLINK-29398][connector/kafka] Provide rack ID to Kafka Source to take advantage of Rack Awareness

["mas-chen (via GitHub)" <gi...@apache.org>]

mas-chen commented on code in PR #20:
URL: https://github.com/apache/flink-connector-kafka/pull/20#discussion_r1231661170


##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSource.java:
##########
@@ -98,20 +98,24 @@
     private final KafkaRecordDeserializationSchema<OUT> deserializationSchema;
     // The configurations.
     private final Properties props;
+    // Client rackId callback
+    private final Supplier<String> rackIdSupplier;

Review Comment:
   This should be a "SerializableSupplier". A supplier may contain a non-serializable client for example



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org