You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/31 18:40:25 UTC

[GitHub] betodealmeida opened a new pull request #5529: Fix time shift

betodealmeida opened a new pull request #5529: Fix time shift
URL: https://github.com/apache/incubator-superset/pull/5529
 
 
   `SelectControl` is not working correctly when both `multi` and `freeForm` are both true — the freeform value is being deleted from the list of choices.
   
   I also improved the code. Currently, for multi it only checks if the **first** value is not present in the choices, and deletes everything if that's true. I changed it so that only values not present in the choices are erased.
   
   This fixes https://github.com/apache/incubator-superset/issues/5520.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org