You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (Created) (JIRA)" <ji...@apache.org> on 2011/10/13 18:59:12 UTC
[jira] [Created] (MATH-690) Remove methods from "MathUtils"
Remove methods from "MathUtils"
-------------------------------
Key: MATH-690
URL: https://issues.apache.org/jira/browse/MATH-690
Project: Commons Math
Issue Type: Task
Reporter: Gilles
Assignee: Gilles
Priority: Trivial
Fix For: 3.0
I propose to remove the following methods from "MathUtils":
public static double sign(final double x)
public static float sign(final float x)
public static double sinh(double x)
public static double cosh(double x)
Also, "sign" and "indicator" functions seem redundant (and the "float" and
"double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126729#comment-13126729 ]
Gilles commented on MATH-690:
-----------------------------
For "byte", "short", "int", "long", do we keep "sign" or "indicator"?
Another alternative would be to replace them with "signum" or "copySign" in order to have a consistent naming with their counterpart in "FastMath".
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157271#comment-13157271 ]
Gilles commented on MATH-690:
-----------------------------
Revision 1206274:
* Implemented "copySign" methods.
* Removed "indicator" methods.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-690.
-------------------------
Resolution: Fixed
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127035#comment-13127035 ]
Gilles commented on MATH-690:
-----------------------------
"sign" removed in revision 1183138.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135474#comment-13135474 ]
Gilles commented on MATH-690:
-----------------------------
The "indicator" functionality could be replaced by a call to "copySign(one, x)" (with "one" being "1" of the appropriate type) _if_ we drop the special case for a "NaN" argument: "indicator" returns "NaN" while "copySign" does not.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Luc Maisonobe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156889#comment-13156889 ]
Luc Maisonobe commented on MATH-690:
------------------------------------
OK with your proposals.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160927#comment-13160927 ]
Gilles commented on MATH-690:
-----------------------------
Revision 1209100:
* Removed "sign" methods.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130005#comment-13130005 ]
Gilles commented on MATH-690:
-----------------------------
Please have a look at revision 1185841.
I've implemented "copySign" for "byte" arguments. It can replace the "sign" method; however, the additional functionality comes at the cost of a more complex method that must also check for overflow.
Shall I go on and implement "copySign" for the other integral types?
Shall I remove "sign"?
The "indicator" methods are slightly different: They return -1 or 1 (whereas "sign", and "copySign", can return 0). There is a single use of it in CM (in class "Complex"). Is it safe to remove them, and replace with "copySign"?
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126995#comment-13126995 ]
Gilles commented on MATH-690:
-----------------------------
"sinh" and "cosh" removed in revision 1183128.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Luc Maisonobe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126747#comment-13126747 ]
Luc Maisonobe commented on MATH-690:
------------------------------------
Yes, consistency is better.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-690) Remove methods from "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160943#comment-13160943 ]
Gilles commented on MATH-690:
-----------------------------
Modified unit tests committed in r1209118.
> Remove methods from "MathUtils"
> -------------------------------
>
> Key: MATH-690
> URL: https://issues.apache.org/jira/browse/MATH-690
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Assignee: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> I propose to remove the following methods from "MathUtils":
> public static double sign(final double x)
> public static float sign(final float x)
> public static double sinh(double x)
> public static double cosh(double x)
> Also, "sign" and "indicator" functions seem redundant (and the "float" and
> "double" versions are not dealing correctly with -0.0).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira