You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/27 21:25:40 UTC

[GitHub] [netbeans] trkatsarski opened a new pull request, #4875: Fix unix launcher shell script java identification issue

trkatsarski opened a new pull request, #4875:
URL: https://github.com/apache/netbeans/pull/4875

   This patch fixes an issue in case the java version used has a whole number (e.g. 19 instead of 19.0.1). In that case it could not be properly parsed.
   
   
   
   
   
   ---
   **^Add meaningful description above**
   
   By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
   
    - are all your own work, and you have the right to contribute them.
    - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
   
   Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
   
   If you're a first time contributor, see the Contributing guidelines for more information.
   
   If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] BradWalker commented on pull request #4875: Fix unix launcher shell script java identification issue

Posted by GitBox <gi...@apache.org>.
BradWalker commented on PR #4875:
URL: https://github.com/apache/netbeans/pull/4875#issuecomment-1294202234

   Hey @trkatsarski 
   
   Can you post was the post the results before and after the fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Fix unix launcher shell script java identification issue [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien closed pull request #4875: Fix unix launcher shell script java identification issue
URL: https://github.com/apache/netbeans/pull/4875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] trkatsarski commented on pull request #4875: Fix unix launcher shell script java identification issue

Posted by GitBox <gi...@apache.org>.
trkatsarski commented on PR #4875:
URL: https://github.com/apache/netbeans/pull/4875#issuecomment-1294081436

   @BradWalker This is the patch related to this issue:
   https://github.com/apache/netbeans/issues/4874
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Fix unix launcher shell script java identification issue [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4875:
URL: https://github.com/apache/netbeans/pull/4875#issuecomment-3226220296

   closing since NBI has been removed https://github.com/apache/netbeans/pull/8283


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #4875: Fix unix launcher shell script java identification issue

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4875:
URL: https://github.com/apache/netbeans/pull/4875#issuecomment-1294770438

   Thanks @trkatsarski Good to see one of various issues in NBI be looked at.  You may have noticed that NetBeans 15 has dropped use of NBI installer for Linux.  It would be good to see more of the issues addressed if NBI is to remain in the platform, but you may also want to consider alternative packaging options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] trkatsarski commented on pull request #4875: Fix unix launcher shell script java identification issue

Posted by GitBox <gi...@apache.org>.
trkatsarski commented on PR #4875:
URL: https://github.com/apache/netbeans/pull/4875#issuecomment-1295913048

   @neilcsmith-net Thank you for the input, I will consider it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] trkatsarski commented on pull request #4875: Fix unix launcher shell script java identification issue

Posted by GitBox <gi...@apache.org>.
trkatsarski commented on PR #4875:
URL: https://github.com/apache/netbeans/pull/4875#issuecomment-1294554943

   > Hey @trkatsarski
   > 
   > Can you post was the post the results before and after the fix?
   
   I could not quite understand, could you add more details?
   If you mean what's the results after applying this fix:
   I came across this issue while debugging a Netbeans Platform based application. Its installers are from the Netbeans IDE platform. And when using a specific version of Java (v19 openjdk from oracle) it couldn't be installed because the Java could not be identified. I saw that Netbeans 13 installer itself also had this issue and found that this was caused by the launcher.sh script. After applying this fix, rebuilding the Netbeans IDE - the Netbeans platform application I was debugging had no issues in identifying the specific Java version mentioned before.
   
   If more specific verbose logs of the installer (before and after the fix) are required, I can provide them but it may take some time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists