You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Michael Osipov (Jira)" <ji...@apache.org> on 2020/02/21 08:46:00 UTC

[jira] [Updated] (HTTPCORE-626) Don't send request body for "Expect: 100-continue" when servers closes connection on non-2xx status code

     [ https://issues.apache.org/jira/browse/HTTPCORE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Osipov updated HTTPCORE-626:
------------------------------------
    Description: 
Based on the discussion in [this|https://www.mail-archive.com/httpclient-users@hc.apache.org/msg09851.html] thread. The expect handling was been changed in a way that it turns out to be pointless. Roy Fielding commented that a server can close a connection on a non-2xx status and the client does not need to send the request body in this case.

In the spirit of this, we shall close the connection immediately w/o sending the request body. It shall only be send if the server does not request to close the connection.
The client can close the connection itself if a non-2xx status has been received and it wishes not to send the request body. Otherwise one must completely the request for the server connection to continue function properly.

This likely only applies when a {{Content-Length}} header has been supplied.

  was:
Based on the discussion in [this|https://www.mail-archive.com/httpclient-users@hc.apache.org/msg09851.html] thread. The expect handling was been changed in a way that it turned out to be pointless. Roy Fielding commented that a server can close a connection on a non-2xx status and the client does not need to send the request body in this case.

In the spirit of this, we shall close the connection immediately w/o sending the request body. It shall only be send if the server does not request to close the connection.
The client can close the connection itself if a non-2xx status has been received and it wishes not to send the request body. Otherwise one must completely the request for the server connection to continue function properly.


> Don't send request body for "Expect: 100-continue" when servers closes connection on non-2xx status code
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-626
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-626
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 5.0-beta11
>            Reporter: Michael Osipov
>            Priority: Major
>
> Based on the discussion in [this|https://www.mail-archive.com/httpclient-users@hc.apache.org/msg09851.html] thread. The expect handling was been changed in a way that it turns out to be pointless. Roy Fielding commented that a server can close a connection on a non-2xx status and the client does not need to send the request body in this case.
> In the spirit of this, we shall close the connection immediately w/o sending the request body. It shall only be send if the server does not request to close the connection.
> The client can close the connection itself if a non-2xx status has been received and it wishes not to send the request body. Otherwise one must completely the request for the server connection to continue function properly.
> This likely only applies when a {{Content-Length}} header has been supplied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org