You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ie...@apache.org on 2020/06/20 20:05:41 UTC

[beam] 02/03: Remove RedisIO.ReadAll transform based on Key Patterns

This is an automated email from the ASF dual-hosted git repository.

iemejia pushed a commit to branch BEAM-9403-redisio-readall-backup
in repository https://gitbox.apache.org/repos/asf/beam.git

commit fd95dfc22efd0a5951894b104cdcffa9d866d9c2
Author: Ismaël Mejía <ie...@gmail.com>
AuthorDate: Mon Apr 13 17:34:52 2020 +0200

    Remove RedisIO.ReadAll transform based on Key Patterns
---
 .../main/java/org/apache/beam/sdk/io/redis/RedisIO.java  | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java b/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
index 77fbb6a..2757f2e 100644
--- a/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
+++ b/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
@@ -131,22 +131,6 @@ public class RedisIO {
         .build();
   }
 
-  /**
-   * Like {@link #read()} but executes multiple instances of the Redis query substituting each
-   * element of a {@link PCollection} as key pattern.
-   *
-   * @deprecated This method is not consistent with the readAll pattern of other transforms and will
-   *     be remove soon. Please update you code to use {@link #readKeyPatterns()} instead.
-   */
-  @Deprecated
-  public static ReadKeyPatterns readAll() {
-    return new AutoValue_RedisIO_ReadKeyPatterns.Builder()
-        .setConnectionConfiguration(RedisConnectionConfiguration.create())
-        .setBatchSize(1000)
-        .setOutputParallelization(true)
-        .build();
-  }
-
   /** Write data to a Redis server. */
   public static Write write() {
     return new AutoValue_RedisIO_Write.Builder()