[jira] [Commented] (FLINK-4499) Introduce findbugs maven plugin

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093022#comment-16093022 ] 

ASF GitHub Bot commented on FLINK-4499:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4367

    [FLINK-4499] Add spotbugs plugin

    This PR introduces the spotbugs maven plugin, which is the successor to findbugs.
    
    This PR is partially based on #2422.
    
    The spotbugs checks can be run with maven by specifying "-Dspotbugs" on the command-line. For travis, this is done on the "misc" test group; the only profile that actually builds all modules.
    
    As for the rules, i deactivated all that currently caused failures. I will create follow-up JIRAs to activate rules one-by-one; this should give result in several PRs that are easy and quick to review, and lessens the chance of some draconian rule from slipping through.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4499

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4367.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4367
    
----
commit b5abfed7ac6b5e9d21bfe90b8a067ddc56668cbb
Author: zentol <ch...@apache.org>
Date:   2017-07-17T14:59:22Z

    [FLINK-4499] Add spotbugs plugin

----


> Introduce findbugs maven plugin
> -------------------------------
>
>                 Key: FLINK-4499
>                 URL: https://issues.apache.org/jira/browse/FLINK-4499
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Ted Yu
>            Assignee: Suneel Marthi
>
> As suggested by Stephan in FLINK-4482, this issue is to add findbugs-maven-plugin into the build process so that we can detect lack of proper locking and other defects automatically.
> We can begin with small set of rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)