[GitHub] [arrow] benibus commented on a diff in pull request #35798: GH-35579: [C++] Support non-named FieldRefs in Parquet scanner

["benibus (via GitHub)" <gi...@apache.org>]

benibus commented on code in PR #35798:
URL: https://github.com/apache/arrow/pull/35798#discussion_r1228396242


##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -248,7 +283,12 @@ Result<std::vector<int>> InferColumnProjection(const parquet::arrow::FileReader&
   }
 
   std::vector<int> columns_selection;
-  for (const auto& ref : field_refs) {
+  for (auto& ref : field_refs) {
+    // In the (unlikely) absence of a known dataset schema, we require that all
+    // materialized refs are named.
+    if (options.dataset_schema) {

Review Comment:
   Haha I figured as much... That being said, some of the existing tests do leave it null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org