You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/27 01:29:48 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #2132: libxx: fix/suppresss warnings
yamt opened a new pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132
## Summary
libxx: fix/suppresss warnings
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2132: libxx: fix/suppresss warnings
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132#issuecomment-716942552
@v01d maybe. if CONFIG_CXX_EXCEPTION=y. anyway i'm not going to implement it in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2132: libxx: fix/suppresss warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132#discussion_r512505070
##########
File path: libs/libxx/cxx.defs
##########
@@ -22,3 +22,14 @@ CXXSRCS += libxx_cxa_guard.cxx libxx_cxapurevirtual.cxx
CXXSRCS += libxx_delete.cxx libxx_delete_sized.cxx libxx_deletea.cxx
CXXSRCS += libxx_deletea_sized.cxx libxx_new.cxx libxx_newa.cxx
CXXSRCS += libxx_stdthrow.cxx
+
+# Note: Our implmenetations of operator new are not conforming to
+# the standard. (no bad_alloc implementation)
+#
+# libxx_new.cxx:64:11: error: 'operator new' is missing exception specification
+# 'throw(std::bad_alloc)' [-Werror,-Wmissing-exception-spec]
Review comment:
But should we implement bad_alloc instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2132: libxx: fix/suppresss warnings
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2132: libxx: fix/suppresss warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132#discussion_r512505070
##########
File path: libs/libxx/cxx.defs
##########
@@ -22,3 +22,14 @@ CXXSRCS += libxx_cxa_guard.cxx libxx_cxapurevirtual.cxx
CXXSRCS += libxx_delete.cxx libxx_delete_sized.cxx libxx_deletea.cxx
CXXSRCS += libxx_deletea_sized.cxx libxx_new.cxx libxx_newa.cxx
CXXSRCS += libxx_stdthrow.cxx
+
+# Note: Our implmenetations of operator new are not conforming to
+# the standard. (no bad_alloc implementation)
+#
+# libxx_new.cxx:64:11: error: 'operator new' is missing exception specification
+# 'throw(std::bad_alloc)' [-Werror,-Wmissing-exception-spec]
Review comment:
But should we implement bad_alloc instead? it's better to confirm the standard instead ignore the warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #2132: libxx: fix/suppresss warnings
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132#issuecomment-716927857
Maybe since libxx supports exceptions we can implement a trivial bad_alloc exception when exceptions are on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2132: libxx: fix/suppresss warnings
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2132:
URL: https://github.com/apache/incubator-nuttx/pull/2132#discussion_r512698479
##########
File path: libs/libxx/cxx.defs
##########
@@ -22,3 +22,14 @@ CXXSRCS += libxx_cxa_guard.cxx libxx_cxapurevirtual.cxx
CXXSRCS += libxx_delete.cxx libxx_delete_sized.cxx libxx_deletea.cxx
CXXSRCS += libxx_deletea_sized.cxx libxx_new.cxx libxx_newa.cxx
CXXSRCS += libxx_stdthrow.cxx
+
+# Note: Our implmenetations of operator new are not conforming to
+# the standard. (no bad_alloc implementation)
+#
+# libxx_new.cxx:64:11: error: 'operator new' is missing exception specification
+# 'throw(std::bad_alloc)' [-Werror,-Wmissing-exception-spec]
Review comment:
@yamt can you open an issue to remind ourselves to fix this? shouldn't be hard
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org