You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/09/21 21:20:26 UTC

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8117


Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................

IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Testing:
========
Ran core tests

Perf:
====
Ran this query a few times:

  set num_nodes=1;
  set mt_dop=1;
  select min(l_returnflag), min(l_linestatus) from biglineitem;
  summary;

I saw a speedup in scan time from ~2.25s -> 2.11s on my machine.

Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 31 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/8117/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8117 )

Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................

IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Testing:
========
Ran core tests

Perf:
====
Ran this query a few times:

  set num_nodes=1;
  set mt_dop=1;
  select min(l_returnflag), min(l_linestatus) from biglineitem;
  summary;

I saw a speedup in scan time from ~2.25s -> 2.11s on my machine.

Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Reviewed-on: http://gerrit.cloudera.org:8080/8117
Reviewed-by: Lars Volker <lv...@cloudera.com>
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 31 insertions(+), 8 deletions(-)

Approvals:
  Lars Volker: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8117 )

Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 23:39:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8117 )

Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 23:06:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8117 )

Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1258/


-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Sep 2017 23:41:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8117 )

Change subject: IMPALA-5965: avoid per-value switch on NeedsConversionInline() in parquet
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04fb4ca73978d0100e1eb9835b87d37540b8b645
Gerrit-Change-Number: 8117
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Sep 2017 03:45:27 +0000
Gerrit-HasComments: No