[GitHub] rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately

[GitBox <gi...@apache.org>]

rdhabalia commented on a change in pull request #2128: Schedule task to update function stats separately
URL: https://github.com/apache/incubator-pulsar/pull/2128#discussion_r201802757
 
 

 ##########
 File path: pulsar-functions/proto/src/main/proto/InstanceCommunication.proto
 ##########
 @@ -72,5 +72,7 @@ message HealthCheckResult {
 service InstanceControl {
     rpc GetFunctionStatus(google.protobuf.Empty) returns (FunctionStatus) {}
     rpc GetAndResetMetrics(google.protobuf.Empty) returns (MetricsData) {}
+    rpc ResetMetrics(google.protobuf.Empty) returns (google.protobuf.Empty) {}
 
 Review comment:
   actually, getAndReset doesn't store any sample because it gets current sample and resets it. right now, it is only used by prometheus to feed into metrics. but if we want to fetch metrics on demand then we want to update metrics (reset) periodically and get metrics on demand. PR #2130 in created on top of this one which aggregates metrics into function stats so, we can always see function metrics on demand using getMetrics api similar like we can get for topic: `pulsar-admin persistent stats <topic>` which gives current topic stats using cli api. also, we can add additional REST api which can generate metrics in different format other than prometheus.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services